[pickers] Keep invalid date state consistent #20040
Open
+205
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
type: regression
|
Deploy preview: https://deploy-preview-20040--material-ui-x.netlify.app/ Bundle size report
|
siriwatknp
reviewed
Oct 30, 2025
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
1 task
| }); | ||
|
|
||
| it('keeps aria-invalid=true while spinning year when month is invalid (non-accessible DOM)', async () => { | ||
| // moment and luxon validation seem to not work |
There was a problem hiding this comment.
That's problematic 😆
Could you elaborate on what doesn't wort and if we can find a workaround?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should keep the invalid state consistent during different phases of the input cycle in the pickers.
This fixes some validation bugs:
Consistent invalid field state
Invalid state "shuffling"
Before:
Screen.Recording.2025-10-30.at.14.52.48.mov
After:
Screen.Recording.2025-10-30.at.14.53.05.mov
Fixes #17967
Fixes #18039
Fixes #18299
Fixes #19777