Skip to content

[DataGrid] Fix AggregationTreeData demo crashing #20103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v6.x
Choose a base branch
from
+14 −0
Open

[DataGrid] Fix AggregationTreeData demo crashing #20103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ffdc2d
[data grid] Fix AggregationTreeData crashing
sai6855 Oct 27, 2025
b3925b9
trigger-ci
sai6855 Oct 30, 2025
919e121
trigger-ci
sai6855 Nov 4, 2025
84cfccc
Trigger CI
MBilalShafi Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/data/data-grid/aggregation/AggregationTreeData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ const columns = [

return new Date(params.value);
},
valueFormatter: (params) => {
if (params.value == null) {
return '';
}

return params.value.toLocaleString();
},
},
];

Expand Down
7 changes: 7 additions & 0 deletions docs/data/data-grid/aggregation/AggregationTreeData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ const columns: GridColDef[] = [

return new Date(params.value);
},
valueFormatter: (params) => {
Copy link
Contributor Author

@sai6855 sai6855 Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the deployment is failing, but we can test the fix by adding this diff in https://v6.mui.com/x/react-data-grid/aggregation/#usage-with-tree-data
.
The demo no longer crashes after applying this change.

CC @Janpot do you have any insight on why deployment is failing?

Copy link
Member

@Janpot Janpot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure. I retried without cache in https://app.netlify.com/projects/material-ui-x/deploys/68ff5479d2d2ded80bddfb03. Seems to work

if (params.value == null) {
return '';
}

return params.value.toLocaleString();
},
},
];

Expand Down