Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 29, 2025

This PR contains the following updates:

Package Change Age Confidence
@mui/internal-babel-plugin-display-name (source) ^1.0.4-canary.7 -> ^1.0.4-canary.8 age confidence
@mui/internal-bundle-size-checker (source) ^1.0.9-canary.53 -> ^1.0.9-canary.54 age confidence
@mui/internal-code-infra (source) ^0.0.3-canary.38 -> ^0.0.3-canary.44 age confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies. label Oct 29, 2025
@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from 6e269e1 to 9b85bb6 Compare October 29, 2025 13:10
@renovate renovate bot changed the title Bump @mui/internal-code-infra to ^0.0.3-canary.39 Bump @mui/internal-code-infra to ^0.0.3-canary.40 Oct 29, 2025
@mui-bot
Copy link

mui-bot commented Oct 29, 2025

Deploy preview: https://deploy-preview-20128--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 593c57f

@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from 9b85bb6 to c138cbc Compare October 29, 2025 14:39
@renovate renovate bot changed the title Bump @mui/internal-code-infra to ^0.0.3-canary.40 Bump @mui/internal-code-infra to ^0.0.3-canary.41 Oct 29, 2025
@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from c138cbc to 4e93100 Compare October 29, 2025 16:40
@renovate renovate bot changed the title Bump @mui/internal-code-infra to ^0.0.3-canary.41 Bump @mui/internal-code-infra to ^0.0.3-canary.42 Oct 29, 2025
@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from 4e93100 to fe8d474 Compare October 30, 2025 06:14
@renovate renovate bot changed the title Bump @mui/internal-code-infra to ^0.0.3-canary.42 Bump @mui/internal-code-infra to ^0.0.3-canary.43 Oct 30, 2025
@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from fe8d474 to 662c128 Compare November 3, 2025 00:58
@renovate renovate bot changed the title Bump @mui/internal-code-infra to ^0.0.3-canary.43 Bump MUI infra packages Nov 3, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/mui-infra-packages branch from 662c128 to a0e52b9 Compare November 3, 2025 08:54
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
],
},
})),
// FIXME: Remove these exceptions once the migration is complete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled the rules because lint was failing with around 1000 problems.

I'll let teams know that they should try to remove their packages from here as they fix the issues.

Copy link
Member

@Janpot Janpot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: https://github.com/mui/mui-x/pull/20120/files#r2481552661

The new version of react-hooks plugin contains the compiler rules. Which are riddled with false positives. I personally wouldn't necessarily spend a lot of time on it yet until we decided the path forward with react compiler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context 👍

@bernardobelchior bernardobelchior requested review from a team November 3, 2025 10:37
@renovate
Copy link
Contributor Author

renovate bot commented Nov 3, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

files: [`packages/${pkgName}/src/**/*${EXTENSION_TS}`],
ignores: ['**/*.d.ts'],
rules: {
'import/export': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have import/export rule errors in these packages?
Disabling it globally seems like an overkill

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some weird bug I've observed when we're re-exporting from a barrel file that itself re-exports from a barrel file in another workspace.

Until we can pinpoint this, we should probably just eslint-disable those specific lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only disabling it in the packages that have lint errors, which are the ones defined in line 446.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we can pinpoint this, we should probably just eslint-disable those specific lines.

The charts team has an export-generation script to ensure consistent exports across community, pro and premium packages that uses the offending syntax.

We could disable it line by line, but I'd need to update the script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, exporting the same name multiple times can cause issues in ES modules, and the rule itself seems to make sense. So I'm just trying to be cautious here and avoid potential issues introduced after the rule is disabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled it line by line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, exporting the same name multiple times can cause issues in ES modules

The problem I observed didn't have to do with re-exports, and rather seems to be a eslint-plugin-import bug.

The charts team has an export-generation script to ensure consistent exports across community, pro and premium packages that uses the offending syntax.

A good demonstration of why it's often better to verify in a lint step rather than generate sources. It leaves the sources available to hand edit.

@bernardobelchior bernardobelchior force-pushed the renovate/mui-infra-packages branch from 47abe25 to 8b95c57 Compare November 3, 2025 15:47
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 10, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 10, 2025
'react-hooks/refs': 'off',
'react-hooks/preserve-manual-memoization': 'off',
'react-hooks/purity': 'off',
'react-hooks/static-components': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels very complicated to do package by package. Can't we just blanket disable these for now across the repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was that each package owner would then fix this lint rules for their packages and remove them from here.

I agree that disabling the rules globally is easier. Let me know if you still prefer that I disable it globally.

Copy link
Member

@Janpot Janpot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you. I'm just not sure it makes sense to spend a lot of time right now fixing them given that they have tons of false positives.

@bernardobelchior bernardobelchior force-pushed the renovate/mui-infra-packages branch from 4978eb3 to 96542c5 Compare November 11, 2025 10:54
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 11, 2025
'react-hooks/globals': 'off',
'react-hooks/refs': 'off',
'react-hooks/static-components': 'off',
},
Copy link
Contributor

@brijeshb42 brijeshb42 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the previous (line 182) config turn this off for all files ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed some parts and forgot to remove this one. Thanks!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 11, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@bernardobelchior bernardobelchior force-pushed the renovate/mui-infra-packages branch from 96542c5 to 3191204 Compare November 11, 2025 11:57
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 11, 2025
@bernardobelchior bernardobelchior force-pushed the renovate/mui-infra-packages branch from 3191204 to 593c57f Compare November 11, 2025 14:09
@bernardobelchior bernardobelchior merged commit 0b08206 into master Nov 11, 2025
21 checks passed
@bernardobelchior bernardobelchior deleted the renovate/mui-infra-packages branch November 11, 2025 14:52
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
bernardobelchior added a commit to bernardobelchior/mui-x that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update of dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants