feat: add proquint multibase #292
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ref: https://github.com/multiformats/multibase/blob/master/rfcs/Proquint.md (for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got fairly low confidence in this, but I had fun doing it.
From what I can see, reference implementations depend on being able to read inputs as 8-bit pairs (i.e. encode and decode in 16-bit chunks), but we need more flexibility than that for multibase so I've taken some liberties in defining what an uneven number of input bytes would do, which you can see in the test fixtures, i.e. instead of a 5 character block, it's a 3 character block, so we overspend by 2 bits.
Need to find other implementations that deal in variable input and output bytes and not just strict 16 or 32 bit ints.
Anyone want to help!?