Skip to content

Conversation

@ireneea
Copy link
Contributor

@ireneea ireneea commented Oct 29, 2025

Summary

  • Added a loading state to the change workflow owner modal
  • Fixed the link in toast success
  • Fixed error message in toast error
Screen.Recording.2025-10-29.at.13.30.03.mov

Related Linear tickets, Github issues, and Community forum posts

Resolves PAY-2994

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ireneea ireneea changed the title Pay 2994 moving workflow to project with credentials causes errors fix: Prevent multiple api requests when changing workflow owner Oct 29, 2025
areAllUsedCredentialsShareable:
shareableCredentials.value.length === usedCredentials.value.length,
}),
onClick: (event: MouseEvent | undefined) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using onClick because RouterLink doesn't work in the toast (Also see change in the ProjectMoveSuccessToastMessage component)

}
} catch (error) {
toast.showError(
error.message,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what was causing the error modal to show undefined

@ireneea ireneea requested review from mutdmour and r00gm October 29, 2025 13:38
@ireneea ireneea marked this pull request as ready for review October 29, 2025 13:39
@bundlemon
Copy link

bundlemon bot commented Oct 29, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
5.89MB (+479.17KB +8.63%) -
**/*.css
218.17KB (+4.91KB +2.3%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/projects/components/ProjectMoveResourceModal.vue 94.44% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@blacksmith-sh

This comment has been minimized.

@currents-bot
Copy link

currents-bot bot commented Nov 3, 2025

E2E Tests: n8n tests passed after 8m 50.1s

🟢 584 · 🔴 0 · ⚪️ 12 · 🟣 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: f539ae2

  • Spec files: 96

  • Overall tests: 596

  • Duration: 8m 50.1s

  • Parallelization: 8

Groups

GroupId Results Spec Files Progress
ui 🟢 529 · 🔴 0 · ⚪️ 12 · 🟣 2 89 / 89
ui:isolated 🟢 55 · 🔴 0 · ⚪️ 0 7 / 7


This message was posted automatically by currents.dev | Integration Settings

@ireneea ireneea merged commit b610e55 into master Nov 3, 2025
38 of 40 checks passed
@ireneea ireneea deleted the pay-2994-moving-workflow-to-project-with-credentials-causes-errors branch November 3, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants