fix(editor): Fix outstanding chat UI bugs (no-changelog) #21413
Conversation
| messageId: ChatMessageId; | ||
| previousMessageId: ChatMessageId | null; | ||
| retryOfMessageId: ChatMessageId | null; | ||
| executionId: number | null; |
There was a problem hiding this comment.
This has no effect in this PR, but along with changes in #21393 this makes it possible to show the link to execution in the chat message action without refreshing the browser.
There was a problem hiding this comment.
On base llm models the execution gets deleted right after the streaming is done, we should make sure we don't show those execution links as user won't be able to follow them 🤔
There was a problem hiding this comment.
Yes, we'll show it for n8n workflow agent only.
There was a problem hiding this comment.
(when the execution gets deleted the column also gets set to NULL on the db)
| const b = messagesGraph[second]; | ||
|
|
||
| // TODO: Disabled for now, messages retried don't get this at the FE before reload | ||
| // TOOD: Do we even need runIndex at all? |
There was a problem hiding this comment.
runIndex is already removed
|
|
||
| const messages = linkMessages(Object.values(conversation.messages)); | ||
|
|
||
| // TOOD: Do we need 'state' column at all? |
There was a problem hiding this comment.
Turned out that we need the state column 😄
There was a problem hiding this comment.
yeah I made it actually somewhat accurate last week
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts">
<violation number="1" location="packages/frontend/editor-ui/src/features/ai/chatHub/chat.store.ts:297">
onBeginMessage adds a duplicate session entry for every stream start. Guard against pushing when the session already exists to avoid duplicating chats in the sidebar.</violation>
</file>
<file name="packages/frontend/editor-ui/src/features/ai/chatHub/ChatView.vue">
<violation number="1" location="packages/frontend/editor-ui/src/features/ai/chatHub/ChatView.vue:186">
The new auto-scroll guard should only follow the streaming prompt when the streaming session matches this view; otherwise the fallback never runs and conversation history stays scrolled away from the latest messages if another chat is actively streaming.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/frontend/editor-ui/src/features/ai/chatHub/ChatView.vue
Outdated
Show resolved
Hide resolved
|
E2E Tests: n8n tests passed after 7m 22.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
|
Got released with |
Summary
This PR fixes several outstanding UI bugs in chat:
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)