fix: Preserve paired item data in pinned data #21417
Draft
+8
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses PAY-2559 where pinned data was losing paired item information. Changes: 1. workflows.store.ts: Store full item object in pinData instead of just json/binary - Changed from: { json: item.json, ...(item.binary && { binary: item.binary }) } - Changed to: item (when isJsonKeyObject) - This preserves pairedItem data along with json and binary 2. workflow-data-proxy.ts: Improve error messaging for paired item failures - Replaced createInvalidPairedItemError with createMissingPairedItemError - Provides better guidance when item pairing fails with pinned data - Removed unused createInvalidPairedItemError function 3. execution-base.error.ts: Fix name property assignment - Use Object.defineProperty to avoid "Cannot assign to read only property" error - More robust than direct assignment 4. Updated test to expect new error message and type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
4 tasks
n8n-assistant
bot
added
core
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Found 11 test failures on Blacksmith runners:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)