-
Notifications
You must be signed in to change notification settings - Fork 1k
Voluntary fees IBC middleware #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sug0
wants to merge
73
commits into
main
Choose a base branch
from
tiago/voluntary-fees-ibc-middleware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d028bf5 to
c1e5d52
Compare
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 18eea0b. ✅ Passed Jobs With Interesting Signals
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tzemanovic
approved these changes
Nov 13, 2025
22817c3 to
18eea0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:api
public API breaking change
breaking:consensus
Consensus breaking change that requires a hard-fork
breaking-change
IBC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4944
Based on #4939
Review: https://github.com/namada-net/namada/pull/4968/files/ed70e61a6aa728c9efa2a42aca24068ebb4888b6..18eea0b7ed599f23df15713592869302a3722533
This PR reworks the now useless Osmosis Shielded Swaps IBC middleware, which was then used to transfer amounts overflowing the min output of a trade to a transparent account.
Its role is now to redirect some funds transferred to a payment address (with memoless IBC shieldings) to a transparent account, to collect IBC shielding fees.
In this PR, it is integrated with the existing Osmosis Shielded Swaps SDK functionality. In Namadillo, an IBC memo must be set when using Keplr to shield funds over to Namada. It should have the following structure:
{ "namada": { "voluntary_fees": { "fee_receiver": "tnam1...", "new_received_amount": "123" } } }Where
new_received_amountis the original amount minus the intended fee.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo