Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 10, 2025

Describe your changes

Closes #4944

Based on #4939
Review: https://github.com/namada-net/namada/pull/4968/files/ed70e61a6aa728c9efa2a42aca24068ebb4888b6..18eea0b7ed599f23df15713592869302a3722533

This PR reworks the now useless Osmosis Shielded Swaps IBC middleware, which was then used to transfer amounts overflowing the min output of a trade to a transparent account.

Its role is now to redirect some funds transferred to a payment address (with memoless IBC shieldings) to a transparent account, to collect IBC shielding fees.

In this PR, it is integrated with the existing Osmosis Shielded Swaps SDK functionality. In Namadillo, an IBC memo must be set when using Keplr to shield funds over to Namada. It should have the following structure:

{
  "namada": {
    "voluntary_fees": {
      "fee_receiver": "tnam1...",
      "new_received_amount": "123"
    }
  }
}

Where new_received_amount is the original amount minus the intended fee.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added IBC breaking-change breaking:consensus Consensus breaking change that requires a hard-fork labels Nov 10, 2025
@sug0 sug0 force-pushed the tiago/voluntary-fees-ibc-middleware branch from d028bf5 to c1e5d52 Compare November 12, 2025 14:45
sug0 added a commit that referenced this pull request Nov 12, 2025
@sug0 sug0 requested a review from grarco November 12, 2025 15:55
@sug0 sug0 marked this pull request as ready for review November 12, 2025 15:55
@sug0 sug0 requested a review from tzemanovic November 12, 2025 15:57
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for 18eea0b.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (0) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
test-e2e (2) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sug0 sug0 added the do-not-merge Do not merge for now label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sug0 sug0 force-pushed the tiago/voluntary-fees-ibc-middleware branch from 22817c3 to 18eea0b Compare November 13, 2025 10:22
@sug0 sug0 removed the do-not-merge Do not merge for now label Nov 13, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking-change IBC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take sustainability fees from IBC shieldings

3 participants