Skip to content

Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tormoder wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook #997

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bfc6a3
Fix NatsUri not reflecting host/port changes from OnConnectingAsync hook
tormoder Nov 10, 2025
d3c6351
Preserve and log resolved URI after OnConnectingAsync hook
tormoder Nov 18, 2025
9009ae3
Merge branch 'main' into fork/tormoder/connect-socket-fix-uri-assignm…
mtmk Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/NATS.Client.Core/NatsConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,8 @@ private async Task ConnectSocketAsync(NatsUri uri)
target = await OnConnectingAsync(target).ConfigureAwait(false);
if (target.Host != uri.Host || target.Port != uri.Port)
{
uri = uri with { Uri = new UriBuilder(uri.Uri) { Host = target.Host, Port = target.Port, }.Uri };
var modifiedUri = new UriBuilder(uri.Uri) { Host = target.Host, Port = target.Port }.Uri;
uri = new NatsUri(modifiedUri.ToString(), uri.IsSeed, uri.Uri.Scheme);
}
}
Comment on lines 476 to 488
Copy link
Member

@mtmk mtmk Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this can be extracted into a method?


Expand Down