-
Notifications
You must be signed in to change notification settings - Fork 5
Norske felter #6909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Norske felter #6909
Conversation
106e341 to
edb70e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR translates field names from English/mixed language to Norwegian across the codebase, following changes in the backend repository (fp-sak PR #7681). The changes standardize API DTOs and form field names to use proper Norwegian naming conventions.
Key Changes:
- Translated field names from English variants to Norwegian (e.g.,
foedselsnummer→fødselsnummer,soker→søker,arsak→årsak) - Removed deprecated fields from API types (
erAktivt,besluttersBegrunnelse,vurderPaNyttArsaker,privatpersonFødselsdato) - Updated API endpoint URL from
/api/behandling/søknadto/api/behandling/soknadfor ASCII compatibility - Refactored test data and storybook fixtures to match new field names
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/types/src/tilbakekreving/behandlingFpTilbake.ts |
Removed deprecated erAktivt field from aksjonspunkt type |
packages/types/src/apiDtoGenerert.ts |
Translated numerous field names to Norwegian, removed deprecated fields, relocated type definitions |
packages/storybook-utils/testdata/lagAksjonspunkt.ts |
Removed erAktivt field from test helper |
packages/prosess/vilkar-svangerskap/src/SvangerskapVilkarProsessIndex.stories.tsx |
Updated story to remove erAktivt field |
packages/papirsoknad/src/foreldrepenger/components/ForeldrepengerForm.tsx |
Updated form field references to Norwegian names |
packages/papirsoknad/src/engangsstonad/components/EngangsstonadForm.tsx |
Updated form field references to Norwegian names |
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanelSvp/TerminOgFodselPanelSvp.tsx |
Translated form field names and variable names |
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanelSvp/TerminFodselSvpPanel.spec.tsx |
Updated test expectations for Norwegian field names |
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanel/TerminOgFodselPanel.tsx |
Translated form field names and variable names |
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanel/TerminOgFodselPanel.spec.tsx |
Updated test expectations for Norwegian field names |
packages/papirsoknad-ui-komponenter/src/permisjonFp/types.ts |
Updated constant and type references |
packages/papirsoknad-ui-komponenter/src/permisjonFp/constants.ts |
Renamed constant from OVERFORING_PERIODE_FIELD_ARRAY_NAME to OVERFØRING_PERIODE_FIELD_ARRAY_NAME |
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/overforeKvote/RenderOverforingAvKvoterFieldArray.tsx |
Updated constant references |
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/overforeKvote/PermisjonOverforingAvKvoterPanel.tsx |
Updated parameter and initial value field names |
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/fulltUttak/RenderPermisjonPeriodeFieldArray.tsx |
Translated prop names |
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/fulltUttak/PermisjonFulltUttak.tsx |
Updated prop values |
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/PermisjonPanel.tsx |
Updated constant references |
packages/papirsoknad-ui-komponenter/src/permisjonFp/PermisjonIndex.spec.tsx |
Updated test expectations |
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/components/types.ts |
Translated type field names |
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/components/OmsorgOgAdopsjonPanel.tsx |
Updated form field references |
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/OmsorgOgAdopsjonPapirsoknadIndex.spec.tsx |
Updated test expectations |
packages/papirsoknad-ui-komponenter/src/lagreSoknadPanel/components/LagreSoknadPanel.tsx |
Translated form field names and variable names |
packages/papirsoknad-ui-komponenter/src/lagreSoknadPanel/LagreSoknadPapirsoknadIndex.spec.tsx |
Updated test expectations |
packages/papirsoknad-ui-komponenter/src/frilansPanel/types.ts |
Translated type field names |
packages/papirsoknad-ui-komponenter/src/frilansPanel/components/FrilansPanel.tsx |
Updated form field references |
packages/papirsoknad-ui-komponenter/src/frilansPanel/FrilansPapirsoknadIndex.spec.tsx |
Updated test expectations |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/types.ts |
Translated type field names |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/components/PermisjonRettigheterPanel.tsx |
Updated form field references and prop names |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/components/OppgiAnnenForelderPanel.tsx |
Updated form field references and transform function |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.tsx |
Updated prop names |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.stories.tsx |
Updated story prop values |
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.spec.tsx |
Updated test expectations |
apps/fp-frontend/src/fagsakprofile/risikoklassifisering/RisikoklassifiseringIndex.stories.tsx |
Removed erAktivt field from story |
apps/fp-frontend/src/fagsakprofile/FagsakProfileIndex.stories.tsx |
Removed erAktivt field from story |
apps/fp-frontend/src/behandling/papirsoknad/BehandlingPapirsoknadIndex.tsx |
Updated API payload field names |
apps/fp-frontend/src/behandling/felles/utils/getAlleMerknaderFraBeslutter.spec.ts |
Removed erAktivt field from test data |
apps/fp-frontend/.storybook/testdata/behandling.ts |
Removed erAktivt field from test data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ges/papirsoknad-ui-komponenter/src/annenForelderPanel/components/OppgiAnnenForelderPanel.tsx
Outdated
Show resolved
Hide resolved
...ges/papirsoknad-ui-komponenter/src/annenForelderPanel/components/OppgiAnnenForelderPanel.tsx
Outdated
Show resolved
Hide resolved
edb70e1 to
890be60
Compare
|



etter denne navikt/fp-sak#7681