Skip to content

Conversation

@palfi
Copy link
Collaborator

@palfi palfi commented Nov 20, 2025

etter denne navikt/fp-sak#7681

@palfi palfi force-pushed the feature/TFP-6009_papir branch 3 times, most recently from 106e341 to edb70e1 Compare November 21, 2025 08:01
@palfi palfi requested a review from sirimykland November 21, 2025 08:16
@palfi palfi marked this pull request as ready for review November 21, 2025 08:16
@palfi palfi requested a review from a team as a code owner November 21, 2025 08:16
@palfi palfi changed the title temp Norske felter Nov 21, 2025
@palfi palfi requested a review from Copilot November 21, 2025 10:41
Copilot finished reviewing on behalf of palfi November 21, 2025 10:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR translates field names from English/mixed language to Norwegian across the codebase, following changes in the backend repository (fp-sak PR #7681). The changes standardize API DTOs and form field names to use proper Norwegian naming conventions.

Key Changes:

  • Translated field names from English variants to Norwegian (e.g., foedselsnummerfødselsnummer, sokersøker, arsakårsak)
  • Removed deprecated fields from API types (erAktivt, besluttersBegrunnelse, vurderPaNyttArsaker, privatpersonFødselsdato)
  • Updated API endpoint URL from /api/behandling/søknad to /api/behandling/soknad for ASCII compatibility
  • Refactored test data and storybook fixtures to match new field names

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/types/src/tilbakekreving/behandlingFpTilbake.ts Removed deprecated erAktivt field from aksjonspunkt type
packages/types/src/apiDtoGenerert.ts Translated numerous field names to Norwegian, removed deprecated fields, relocated type definitions
packages/storybook-utils/testdata/lagAksjonspunkt.ts Removed erAktivt field from test helper
packages/prosess/vilkar-svangerskap/src/SvangerskapVilkarProsessIndex.stories.tsx Updated story to remove erAktivt field
packages/papirsoknad/src/foreldrepenger/components/ForeldrepengerForm.tsx Updated form field references to Norwegian names
packages/papirsoknad/src/engangsstonad/components/EngangsstonadForm.tsx Updated form field references to Norwegian names
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanelSvp/TerminOgFodselPanelSvp.tsx Translated form field names and variable names
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanelSvp/TerminFodselSvpPanel.spec.tsx Updated test expectations for Norwegian field names
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanel/TerminOgFodselPanel.tsx Translated form field names and variable names
packages/papirsoknad-ui-komponenter/src/terminOgFodselPanel/TerminOgFodselPanel.spec.tsx Updated test expectations for Norwegian field names
packages/papirsoknad-ui-komponenter/src/permisjonFp/types.ts Updated constant and type references
packages/papirsoknad-ui-komponenter/src/permisjonFp/constants.ts Renamed constant from OVERFORING_PERIODE_FIELD_ARRAY_NAME to OVERFØRING_PERIODE_FIELD_ARRAY_NAME
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/overforeKvote/RenderOverforingAvKvoterFieldArray.tsx Updated constant references
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/overforeKvote/PermisjonOverforingAvKvoterPanel.tsx Updated parameter and initial value field names
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/fulltUttak/RenderPermisjonPeriodeFieldArray.tsx Translated prop names
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/fulltUttak/PermisjonFulltUttak.tsx Updated prop values
packages/papirsoknad-ui-komponenter/src/permisjonFp/components/PermisjonPanel.tsx Updated constant references
packages/papirsoknad-ui-komponenter/src/permisjonFp/PermisjonIndex.spec.tsx Updated test expectations
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/components/types.ts Translated type field names
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/components/OmsorgOgAdopsjonPanel.tsx Updated form field references
packages/papirsoknad-ui-komponenter/src/omsorgOgAdopsjonPanel/OmsorgOgAdopsjonPapirsoknadIndex.spec.tsx Updated test expectations
packages/papirsoknad-ui-komponenter/src/lagreSoknadPanel/components/LagreSoknadPanel.tsx Translated form field names and variable names
packages/papirsoknad-ui-komponenter/src/lagreSoknadPanel/LagreSoknadPapirsoknadIndex.spec.tsx Updated test expectations
packages/papirsoknad-ui-komponenter/src/frilansPanel/types.ts Translated type field names
packages/papirsoknad-ui-komponenter/src/frilansPanel/components/FrilansPanel.tsx Updated form field references
packages/papirsoknad-ui-komponenter/src/frilansPanel/FrilansPapirsoknadIndex.spec.tsx Updated test expectations
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/types.ts Translated type field names
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/components/PermisjonRettigheterPanel.tsx Updated form field references and prop names
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/components/OppgiAnnenForelderPanel.tsx Updated form field references and transform function
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.tsx Updated prop names
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.stories.tsx Updated story prop values
packages/papirsoknad-ui-komponenter/src/annenForelderPanel/AnnenForelderPapirsoknadIndex.spec.tsx Updated test expectations
apps/fp-frontend/src/fagsakprofile/risikoklassifisering/RisikoklassifiseringIndex.stories.tsx Removed erAktivt field from story
apps/fp-frontend/src/fagsakprofile/FagsakProfileIndex.stories.tsx Removed erAktivt field from story
apps/fp-frontend/src/behandling/papirsoknad/BehandlingPapirsoknadIndex.tsx Updated API payload field names
apps/fp-frontend/src/behandling/felles/utils/getAlleMerknaderFraBeslutter.spec.ts Removed erAktivt field from test data
apps/fp-frontend/.storybook/testdata/behandling.ts Removed erAktivt field from test data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@palfi palfi force-pushed the feature/TFP-6009_papir branch from edb70e1 to 890be60 Compare November 21, 2025 10:53
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants