legg til reusable knip action #326
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Slett forrige kommentar fra Knip | ||
| if: github.event.pull_request.number | ||
| shell: bash | ||
| continue-on-error: true | ||
| run: gh pr comment ${{ github.event.pull_request.number }} --delete-last --yes | ||
| env: | ||
| GITHUB_TOKEN: ${{ inputs.github-token }} | ||
|
|
||
| - name: Post Knip rapport | ||
| if: github.event.pull_request.number | ||
| shell: bash | ||
| run: | | ||
| number_of_words=$(wc -w < knip-report.md) | ||
| if [ $number_of_words -gt 3 ]; then | ||
| gh pr comment ${{ github.event.pull_request.number }} --body-file knip-report.md | ||
| fi | ||
| env: | ||
| GITHUB_TOKEN: ${{ inputs.github-token }} | ||
|
|
There was a problem hiding this comment.
The --delete-last flag deletes the last comment by any user on the PR, not just comments from this action. This could accidentally delete unrelated comments. Consider using a comment identifier or marker to target only Knip comments, or use a dedicated action like marocchino/sticky-pull-request-comment that can update/replace specific comments.
| - name: Slett forrige kommentar fra Knip | |
| if: github.event.pull_request.number | |
| shell: bash | |
| continue-on-error: true | |
| run: gh pr comment ${{ github.event.pull_request.number }} --delete-last --yes | |
| env: | |
| GITHUB_TOKEN: ${{ inputs.github-token }} | |
| - name: Post Knip rapport | |
| if: github.event.pull_request.number | |
| shell: bash | |
| run: | | |
| number_of_words=$(wc -w < knip-report.md) | |
| if [ $number_of_words -gt 3 ]; then | |
| gh pr comment ${{ github.event.pull_request.number }} --body-file knip-report.md | |
| fi | |
| env: | |
| GITHUB_TOKEN: ${{ inputs.github-token }} | |
| - name: Post/oppdater Knip rapport | |
| if: github.event.pull_request.number | |
| uses: marocchino/sticky-pull-request-comment@v2 | |
| with: | |
| header: knip-report | |
| path: knip-report.md | |
| GITHUB_TOKEN: ${{ inputs.github-token }} |
| - name: Slett forrige kommentar fra Knip | ||
| if: github.event.pull_request.number |
There was a problem hiding this comment.
The condition github.event.pull_request.number evaluates to true even when the number is 0 (which shouldn't occur but is safer to guard against). Use github.event.pull_request.number != '' or github.event_name == 'pull_request' for more robust checking.
| required: false | ||
| type: string | ||
| description: Hvilken package manager en skal bruke (npm|pnpm|yarn) | ||
| description: Hvilken package manager en skal brukes (pnpm|yarn). |
har testet at den funker her:
https://github.com/navikt/fp-frontend/actions/runs/19733664478/job/56540378914