Rapid

[joarau]

No description provided.

[Copilot]

Pull Request Overview

This PR integrates Rapids/Rivers event-driven messaging and adds support for recruitment meeting notifications ("rekrutteringstreff") alongside the existing job posting notifications.

Key changes:

• Integration of Rapids/Rivers framework for consuming Kafka events
• New event listeners for kandidat.invitert and invitert.kandidat.endret events
• Refactoring of data model to support multiple notification types (stilling and rekrutteringstreff)
• New API endpoints for recruitment meeting notifications and message templates

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
build.gradle.kts	Added Rapids/Rivers dependency and upgraded Kotlin version (with issue)
Main.kt	Refactored application startup to integrate Rapids connection and event listeners
TestRapid.kt	New test utility for Rapids-based testing with loop detection
KandidatInvitertLytter.kt	New event listener for candidate invitation events
InvitertTreffKandidatEndretLytter.kt	New event listener for recruitment meeting change events
MinsideVarsel.kt	Refactored to use generic avsenderReferanseId instead of stillingId
Mal.kt	Added new message templates for recruitment meetings with URL generation
VarslerApi.kt	Added new endpoint for retrieving recruitment meeting notifications
MeldingsmalApi.kt	Added separate endpoints for stilling and rekrutteringstreff templates
VarselService.kt	New service for creating notifications from event data
MinsideServices.kt	Updated to handle notifications without stilling data
MinsideClient.kt	Updated to generate dynamic URLs based on notification type
KubernetesHealthApi.kt	Added Rapids health checks
Javalin.kt	Updated to pass Rapids instance to health checks
LocalApp.kt	Refactored to use native HttpClient instead of Fuel library
FakeMinside.kt	Updated MockProducer initialization (with issue)
*Test.kt files	Multiple test files added/updated for new functionality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistency: fnr is defined as an array ["12345678901"] but should be a string "12345678901" to match the listener's expected format and the test on line 60.

Suggested change

	"fnr": ["12345678901"]
	"fnr": "12345678901"

[Copilot]

The MockProducer constructor is being called with null as the first parameter. According to the MockProducer API, the first parameter should be a boolean autoComplete. This should be true instead of null to match the original behavior (line 16 shows true was intended).

Suggested change

	null,
	StringSerializer(),
	StringSerializer(),
	StringSerializer(),

[Copilot]

[nitpick] Missing space after comparison operator. Should be index >= kjørFra for consistency with Kotlin style.

Suggested change

	messages.filterIndexed { index, _ -> index>=kjørFra }.forEach { (key, message) ->
	messages.filterIndexed { index, _ -> index >= kjørFra }.forEach { (key, message) ->

[frodank]

Forvirrende med forskjellige event-name(?):
invitert.kandidat.endret
kandidat.invitert

[frodank]

backgroundThread prøver å restarte rapiden om den krasjer.