Adding JSON Helper and interfaces #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nocturnalnematode
approved these changes
Mar 17, 2025
Contributor
nocturnalnematode
left a comment
nocturnalnematode
left a comment
There was a problem hiding this comment.
lgtm. ville ha rebaset oppå master fremfor å merge den inn, for å få litt tydeligere historikk.
ville også vurdert å faktorisere ut compareMaps etc fra compareObjects, men det er en smakssak.
Contributor
Author
|
Eit god poeng med faktorisere ut compareMaps etc fra compareObjects. Eg tenkte ikkje på det i farten, men normalt ville eg ha gjort det. Lurer på å rette det opp før eg merger. Ellers takk fot at du fiksa ChatGPT teksten min. :-D |
Signed-off-by: THS <[email protected]>
torhakon
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.