Skip to content

Conversation

@tlrmchlsmth
Copy link
Member

@tlrmchlsmth tlrmchlsmth commented May 6, 2025

Benchmarking script and modifications to the toy proxy server to benchmark one request at a time. Since we can't turn off prefix caching for P/D, we reset the prefix caches between requests.

This is a worst-case benchmark for P/D to expose the TTFT overheads and a test to measure and optimize the KV transfer.

Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
@github-actions
Copy link

github-actions bot commented May 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat marked this pull request as ready for review May 6, 2025 22:44
@tlrmchlsmth tlrmchlsmth merged commit 5449cf0 into disagg_pd_dev May 6, 2025
2 checks passed
njhill pushed a commit that referenced this pull request May 10, 2025
…#79)

* Benchmark one concurrent req

Signed-off-by: Tyler Michael Smith <[email protected]>

* Updates

Signed-off-by: Tyler Michael Smith <[email protected]>

* restore

Signed-off-by: Tyler Michael Smith <[email protected]>

* Improve random requests, switch up initial test

Signed-off-by: Tyler Michael Smith <[email protected]>

---------

Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
robertgshaw2-redhat pushed a commit that referenced this pull request May 14, 2025
…#79)

* Benchmark one concurrent req

Signed-off-by: Tyler Michael Smith <[email protected]>

* Updates

Signed-off-by: Tyler Michael Smith <[email protected]>

* restore

Signed-off-by: Tyler Michael Smith <[email protected]>

* Improve random requests, switch up initial test

Signed-off-by: Tyler Michael Smith <[email protected]>

---------

Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants