Skip to content

Conversation

@svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Nov 25, 2025

Description

Added essential partial granularity logic to keep entry spans, llm spans and any exit spans that have entity relationship attributes AND those exit spans need to only keep the entity relationship attributes and error attributes (if any) and drop custom attributes.

This is blocked until #3540 is merged and then I need to rebase the PR.

How to Test

Run npm run test

Related Issues

Closes #3456

TODO

  • Rebase PR

@svetlanabrennan svetlanabrennan changed the title Add partial essential granularity feat: Added essential type for partial granularity traces Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (36d907f) to head (caa9e05).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3542       +/-   ##
===========================================
+ Coverage   81.53%   97.64%   +16.11%     
===========================================
  Files         415      426       +11     
  Lines       54603    56021     +1418     
  Branches        1        1               
===========================================
+ Hits        44520    54704    +10184     
+ Misses      10083     1317     -8766     
Flag Coverage Δ
integration-tests-cjs-20.x 73.91% <76.15%> (?)
integration-tests-cjs-22.x 73.95% <76.15%> (?)
integration-tests-cjs-24.x 74.71% <76.15%> (?)
integration-tests-esm-20.x 52.65% <40.39%> (?)
integration-tests-esm-22.x 52.70% <40.39%> (?)
integration-tests-esm-24.x 53.90% <40.39%> (+<0.01%) ⬆️
unit-tests-20.x 88.73% <100.00%> (?)
unit-tests-22.x 88.76% <100.00%> (?)
unit-tests-24.x 88.77% <100.00%> (?)
versioned-tests-20.x 81.04% <77.48%> (?)
versioned-tests-22.x 81.05% <77.48%> (-0.34%) ⬇️
versioned-tests-24.x 80.99% <77.48%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ svetlanabrennan
✅ amychisholm03
❌ newrelic-node-agent-team
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ amychisholm03
✅ svetlanabrennan
❌ newrelic-node-agent-team
You have signed the CLA already but the status is still pending? Let us recheck it.

@svetlanabrennan svetlanabrennan force-pushed the add-partial-essential-granularity branch from af29d09 to cfa8f41 Compare December 2, 2025 22:02
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

Add support for "essential" partial granularity

2 participants