Skip to content

Conversation

@puneetsarna
Copy link
Contributor

@puneetsarna puneetsarna commented Nov 11, 2025

We have cases where users will have network
attachments with a list of projects allowed on it. We are making changes to the service to handle
this better and float the error to the user.

This change calls out what the user sees and
should do in a situation where flow they have
project allowlists on the network attachment.

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@puneetsarna puneetsarna requested review from a team as code owners November 11, 2025 22:15
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 11, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1429/

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM from a docs style perspective

@puneetsarna puneetsarna force-pushed the ps-dev-ne-docs branch 2 times, most recently from 08b2a17 to 6695bfc Compare November 15, 2025 00:45
Copy link

@amudukutore amudukutore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puneetsarna - I'm okay committing these changes as is but would prefer to incorporate the minor suggestions on calling out some of these changes more explicitly (it's up to you). I'm approving this either way.

We have cases where users will have network
attachments with a list of projects allowed on it.
We are making changes to the service to handle
this better and float the error to the user.

This change calls out what the user sees and
should do in a situation where  flow they have
project allowlists on the network attachment.
@puneetsarna puneetsarna merged commit abe6fe0 into main Nov 17, 2025
9 checks passed
@puneetsarna puneetsarna deleted the ps-dev-ne-docs branch November 17, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants