WIP: feat: support strip for all archive

lib/utils.js

@@ -88,8 +88,12 @@
       throw error;
     }
 
+    const strip = opts.strip ? Number(opts.strip) : 0;
+    // Strip is handled here in makeUncompressFn, so remove it from opts to avoid passing to UncompressStream
+    delete opts.strip;
+
     return new Promise((resolve, reject) => {
       fs.mkdir(destDir, { recursive: true }, err => {
         if (err) return reject(err);
 
         let entryCount = 0;
@@ -108,11 +112,10 @@
           .on('error', reject)
           .on('entry', (header, stream, next) => {
             stream.on('end', next);
-            const destFilePath = path.join(destDir, header.name);
-
+            const destFilePath = path.join(destDir, stripFileName(strip, header.name, header.type));
             if (header.type === 'file') {
               const dir = path.dirname(destFilePath);
               fs.mkdir(dir, { recursive: true }, err => {
                 if (err) return reject(err);
 
                 entryCount++;
@@ -127,18 +130,18 @@
               const target = path.resolve(dir, header.linkname);
               entryCount++;
 
               fs.mkdir(dir, { recursive: true }, err => {
                 if (err) return reject(err);
 
                 const relativeTarget = path.relative(dir, target);
                 fs.symlink(relativeTarget, destFilePath, err => {
                   if (err) return reject(err);
                   successCount++;
                   stream.resume();
                 });
               });
             } else { // directory
               fs.mkdir(destFilePath, { recursive: true }, err => {
                 if (err) return reject(err);
                 stream.resume();
               });

test/zip/index.test.js

@@ -288,7 +288,7 @@ describe('test/zip/index.test.js', () => {
     fs.mkdirSync(destDir, { recursive: true });
     await compressing.zip.uncompress(destFile, destDir);
     const stat = fs.statSync(path.join(destDir, 'bin'));
-    assert(stat.mode === originStat.mode);
+    assert.equal(stat.mode, originStat.mode, 'file mode should be same after uncompress');
     // console.log(destDir);
   });
 });

test/zip/uncompress_stream.test.js

@@ -193,23 +193,24 @@ describe('test/zip/uncompress_stream.test.js', () => {
     pump(sourceStream, uncompressStream, err => {
       assert(!err);
       const res = dircompare.compareSync(originalDir, destDir);
-      assert(res.distinct === 0);
-      assert(res.equal === 5);
+      assert.equal(res.distinct, 0, 'distinct files count mismatch');
+      assert.equal(res.equal, 5, 'equal files count mismatch');
       assert(res.totalFiles === 4);
       assert(res.totalDirs === 1);
       done();
     });
 
     uncompressStream.on('entry', (header, stream, next) => {
-      stream.on('end', next);
-
       if (header.type === 'file') {
-        stream.pipe(fs.createWriteStream(path.join(destDir, header.name)));
+        pipelinePromise(stream, fs.createWriteStream(path.join(destDir, header.name)))
+          .then(next)
+          .catch(done);
       } else { // directory
         fs.mkdir(path.join(destDir, header.name), { recursive: true }, err => {
           if (err) return done(err);
           stream.resume();
         });
+        stream.on('end', next);
       }
     });
   });
@@ -231,15 +232,16 @@ describe('test/zip/uncompress_stream.test.js', () => {
     });
 
     uncompressStream.on('entry', (header, stream, next) => {
-      stream.on('end', next);
-
       if (header.type === 'file') {
-        stream.pipe(fs.createWriteStream(path.join(destDir, header.name)));
+        pipelinePromise(stream, fs.createWriteStream(path.join(destDir, header.name)))
+          .then(next)
+          .catch(done);
       } else { // directory
         fs.mkdir(path.join(destDir, header.name), { recursive: true }, err => {
           if (err) return done(err);
           stream.resume();
         });
+        stream.on('end', next);
       }
     });
   });