Skip to content

Conversation

Copy link

Copilot AI commented Aug 8, 2025

This PR updates the project's oxlint configuration to use the shared @eggjs/oxlint-config package instead of maintaining a large inline configuration.

Changes Made

  • Added dependency: Installed @eggjs/oxlint-config@^1.0.0 as a dev dependency
  • Simplified configuration: Replaced the 143-line .oxlintrc.json with a minimal 15-line extends-based configuration
  • Preserved project-specific settings:
    • Kept mocha environment (in addition to node from base config)
    • Maintained project-specific ignorePatterns for index.d.ts, test/fixtures/**, and __snapshots__
    • Override no-console rule to "warn" and no-empty-function to "allow" to match original project behavior

Benefits

  • Reduced maintenance burden: 132 fewer lines of configuration to maintain
  • Automatic updates: Linting rules will be updated automatically when upgrading the shared config
  • Consistency: Uses the same linting rules as other EggJS ecosystem projects
  • Fixed linting issues: Resolves previous errors related to import/consistent-type-specifier-style

Verification

  • ✅ All linting passes with 0 warnings and 0 errors
  • ✅ Build process works correctly with npm run prepublishOnly
  • ✅ Lint-staged and husky hooks continue to work properly
  • oxlint --fix functionality works as expected

The configuration now leverages the shared, community-maintained rules while preserving the project's specific requirements.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​eggjs/​oxlint-config@​1.0.0701007992100

View full report

Copilot AI changed the title [WIP] update oxlint config to use @eggjs/oxlint-config Update oxlint config to use @eggjs/oxlint-config Aug 8, 2025
Copilot AI requested a review from fengmk2 August 8, 2025 14:07
Copilot finished work on behalf of fengmk2 August 8, 2025 14:07
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.40%. Comparing base (46b4acf) to head (6caa171).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files          15       15           
  Lines        1443     1443           
  Branches      291      291           
=======================================
  Hits         1319     1319           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 changed the title Update oxlint config to use @eggjs/oxlint-config chore: update oxlint config to use @eggjs/oxlint-config Aug 9, 2025
@fengmk2 fengmk2 marked this pull request as ready for review August 9, 2025 02:05
@coderabbitai
Copy link

coderabbitai bot commented Aug 9, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fengmk2 fengmk2 merged commit 798a8d1 into master Aug 9, 2025
8 of 9 checks passed
@fengmk2 fengmk2 deleted the copilot/fix-1f7ec4c4-46bf-4180-b085-15b478c1b107 branch August 9, 2025 02:05
fengmk2 pushed a commit that referenced this pull request Aug 9, 2025
[skip ci]

## <small>2.5.1 (2025-08-09)</small>

* fix: patch File to support test on Node.js 18 (#31) ([93edf11](93edf11)), closes [#31](#31)
* chore: remove eslint deps (#28) ([46b4acf](46b4acf)), closes [#28](#28)
* chore: update oxlint config to use @eggjs/oxlint-config (#30) ([798a8d1](798a8d1)), closes [#30](#30)
@github-actions
Copy link

github-actions bot commented Aug 9, 2025

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants