Skip to content

Conversation

@canerakdas
Copy link
Member

Description

Fixes the mobile navigation issue on blog pages

Validation

When a user selects a category from the dropdown on the blog pages, they should be redirected to the corresponding category page

Related Issues

Fixes #8296

Copilot AI review requested due to automatic review settings October 31, 2025 16:51
@canerakdas canerakdas requested a review from a team as a code owner October 31, 2025 16:51
@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 31, 2025 4:52pm

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (a2bd7da) to head (9e1af7d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8302   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files         117      117           
  Lines        9746     9746           
  Branches      328      328           
=======================================
  Hits         7466     7466           
  Misses       2278     2278           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom link components in the StatelessSelect component used by BaseLinkTabs. The change enables the dropdown select to use the same custom link component (e.g., Next.js Link, React Router Link) as the tab buttons.

  • Passes the as prop (containing the custom Component) to StatelessSelect

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@canerakdas
Copy link
Member Author

With this PR, only fixed the redirection issue, but I don’t quite understand why we’re using StatelessSelect directly. We should use WithNoScriptSelect and fall back to the StatelessSelect component only when JavaScript is disabled

StatelessSelect alone is unlikely to provide the accessibility benefits we achieve with Radix, so it should only be used as a last resort 🪳

@canerakdas
Copy link
Member Author

Requesting fast-track, as this fixes an issue that was a blocker for mobile users. @nodejs/nodejs-website

@avivkeller avivkeller added this pull request to the merge queue Oct 31, 2025
@avivkeller
Copy link
Member

With this PR, only fixed the redirection issue, but I don’t quite understand why we’re using StatelessSelect directly. We should use WithNoScriptSelect and fall back to the StatelessSelect component only when JavaScript is disabled

We are using it so we can render this component entirely on the server-side

@ovflowd
Copy link
Member

ovflowd commented Oct 31, 2025

With this PR, only fixed the redirection issue, but I don’t quite understand why we’re using StatelessSelect directly. We should use WithNoScriptSelect and fall back to the StatelessSelect component only when JavaScript is disabled

We are using it so we can render this component entirely on the server-side

But that select is still not compatible with JavaScript being disabled, no? So even being Stateless, does it work with JS disabled?

Merged via the queue into nodejs:main with commit 78f6e90 Oct 31, 2025
18 checks passed
@avivkeller
Copy link
Member

So even being Stateless, does it work with JS disabled?

Yes. JavaScript is not needed to use the StatelessSelect, as it uses the <details /> component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatelessSelect is not clickable on blog page

3 participants