-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: Mobile navigation issue on blog pages #8302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8302 +/- ##
=======================================
Coverage 76.60% 76.60%
=======================================
Files 117 117
Lines 9746 9746
Branches 328 328
=======================================
Hits 7466 7466
Misses 2278 2278
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom link components in the StatelessSelect component used by BaseLinkTabs. The change enables the dropdown select to use the same custom link component (e.g., Next.js Link, React Router Link) as the tab buttons.
- Passes the
asprop (containing the custom Component) toStatelessSelect
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
With this PR, only fixed the redirection issue, but I don’t quite understand why we’re using
|
|
Requesting fast-track, as this fixes an issue that was a blocker for mobile users. @nodejs/nodejs-website |
We are using it so we can render this component entirely on the server-side |
But that select is still not compatible with JavaScript being disabled, no? So even being Stateless, does it work with JS disabled? |
Yes. JavaScript is not needed to use the StatelessSelect, as it uses the |
Description
Fixes the mobile navigation issue on blog pages
Validation
When a user selects a category from the dropdown on the blog pages, they should be redirected to the corresponding category page
Related Issues
Fixes #8296