Skip to content

docs(learn): correct the example code for Streaming Responses with Undici #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

docs(learn): correct the example code for Streaming Responses with Undici #8327

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b391c9b
parse JSON at the end of the stream and use status code from the resp…
NunoMCP Nov 4, 2025
b926b56
Add log
NunoMCP Nov 4, 2025
18a1731
Update apps/site/pages/en/learn/getting-started/fetch.md
NunoMCP Nov 4, 2025
ad1a5f1
make prettier happy
NunoMCP Nov 6, 2025
268eea3
trigger build
NunoMCP Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions apps/site/pages/en/learn/getting-started/fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,12 @@ try {

```js
import { Writable } from 'stream';

import { stream } from 'undici';

async function fetchGitHubRepos() {
const url = 'https://api.github.com/users/nodejs/repos';

const { statusCode } = await stream(
await stream(
url,
{
method: 'GET',
Expand All @@ -149,35 +148,31 @@ async function fetchGitHubRepos() {
Accept: 'application/json',
},
},
() => {
(res) => {
let buffer = '';

return new Writable({
write(chunk, encoding, callback) {
buffer += chunk.toString();

callback();
},
final(callback) {
try {
const json = JSON.parse(buffer);
console.log(
'Repository Names:',
json.map(repo => repo.name)
);
buffer = '';
} catch (error) {
console.error('Error parsing JSON:', error);
}

callback();
},
final(callback) {
console.log('Stream processing completed.');
console.log(`Response status: ${res.statusCode}`);
callback();
},
});
}
);

console.log(`Response status: ${statusCode}`);
}

fetchGitHubRepos().catch(console.error);
Expand Down