-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: rename certifications to courses #8359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
per marketing
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
cc @nodejs/marketing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8359 +/- ##
==========================================
+ Coverage 76.23% 76.27% +0.04%
==========================================
Files 118 118
Lines 9903 9903
Branches 337 336 -1
==========================================
+ Hits 7550 7554 +4
+ Misses 2351 2347 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the navigation bar label from "Certification" to "Courses" in response to a marketing requirement. The change is intentionally limited to avoid a large-scale refactor, as noted by the author that this is temporary.
Key Changes:
- Updates the English locale file to change the certification navigation link text from "Certification" to "Courses"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT I but feel strange to have learn/courses aside. What if we remove it ?
this was the ask - it sounds temporary, but i defer to @nodejs/marketing and @kyliewd specifically |
|
please keep it on for now. more to come on how to frame it in the new year |
per marketing
Description
Per marketing within #8355 (comment)
This being temporary, I have elected not to make this a large refactor of keys
Validation
Related Issues
closes #8355
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.