Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented Nov 21, 2025

Description

Per marketing within #8355 (comment)

This being temporary, I have elected not to make this a large refactor of keys

Validation

image

Related Issues

closes #8355

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner November 21, 2025 12:51
Copilot AI review requested due to automatic review settings November 21, 2025 12:51
@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 21, 2025 0:51am

@bmuenzenmeyer
Copy link
Contributor Author

cc @nodejs/marketing

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.27%. Comparing base (cf7233e) to head (4a3885c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8359      +/-   ##
==========================================
+ Coverage   76.23%   76.27%   +0.04%     
==========================================
  Files         118      118              
  Lines        9903     9903              
  Branches      337      336       -1     
==========================================
+ Hits         7550     7554       +4     
+ Misses       2351     2347       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot finished reviewing on behalf of bmuenzenmeyer November 21, 2025 12:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the navigation bar label from "Certification" to "Courses" in response to a marketing requirement. The change is intentionally limited to avoid a large-scale refactor, as noted by the author that this is temporary.

Key Changes:

  • Updates the English locale file to change the certification navigation link text from "Certification" to "Courses"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT I but feel strange to have learn/courses aside. What if we remove it ?

@bmuenzenmeyer
Copy link
Contributor Author

What if we remove it ?

this was the ask - it sounds temporary, but i defer to @nodejs/marketing and @kyliewd specifically

@kyliewd
Copy link

kyliewd commented Nov 21, 2025

please keep it on for now. more to come on how to frame it in the new year

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 23, 2025
Merged via the queue into main with commit 508977a Nov 23, 2025
18 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the rename-certs-to-courses branch November 23, 2025 13:51
dario-piotrowicz pushed a commit to dario-piotrowicz/nodejs.org that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js Certification has been retired

7 participants