Skip to content

Conversation

@fabiano-santos-nubank
Copy link

Status

READY

Todo list

  • Documentation
  • Tests added and passed

Background context

We are extending the fklearn capabilities with unsupervised algorithm support. First, we proposed to use k-means clustering implementation from scikit-learn since it is a simple and relevant unsupervised algorithm.

Description of the changes proposed in the pull request

  • Add kmeans learner using scikit-learn K-means implementation

  • Add Silhouette Coefficient to evaluate unsupervised results

  • Add Davies-Bouldin score to evaluate unsupervised results

  • Add generic_unsupervised_sklearn_evaluator method in order to provide support to scikit-learn unsupervised metrics

Where should the reviewer start?

kmeans_learner method at src/fklearn/training/unsupervised.py. Then, the unsupervised evaluation metrics at src/fklearn/validation/evaluators.py.

* Add kmeans learner using scikit-learn K-means implementation

* Add Silhouette Coefficient ()

* Add Davies-Bouldin score to evaluate unsupervised results

* Add generic_unsupervised_sklearn_evaluator method to add support to scikit-learn unsupervised metrics
@fabiano-santos-nubank fabiano-santos-nubank requested a review from a team as a code owner December 12, 2022 19:30
@fabiano-santos-nubank fabiano-santos-nubank added the review-request Waiting to be reviewed label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-request Waiting to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants