Add support for AfterLastTestMethodErrored for use in Pest
#336
+38
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into an error in Pest 4 that was reported a while back in 3.7.2 where
AfterLastTestMethodErroredevents are being passed intofromBeforeFirstTestMethodErrored.Though the original issue was closed, if we look at Pest's source, it is simply ignoring a PHPStan error that this could happen.
https://github.com/pestphp/pest/blob/08b09f2e98fc6830050c0237968b233768642d46/src/Support/StateGenerator.php#L34
To resolve this issue in Pest, Collision must support both kinds of test errors.
Because these errors seem like they can be handled in a common way, I created a single function that can receive both, but then kept the specific ones to not break backwards compatibility.
Pest could then take advantage of that single function to handle both cases and remove the PHPStan ignore
If this gets published I can follow up with the Pest PR in that repository.