fix(SaaS): Move docs layout to nested page layout for transitions, add transitions #229
+233
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
FYI header bug was from the deps bug in Nuxt 4.2.0. Please dont feel bad about saying we dont want to do this. Some documentation on this pattern would also be good so people dont struggling navigating this issues themselves. Maybe thats more appropriate for the Nuxt docs. This was a quick example PR of how I solved the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #228
I do notice a bug where the header of the page hero (index) disappears when you navigate back to the homepage, but couldnt figure out why.
Happy to remove the transitions and wrapping div's also but I think showing this structure will be helpful, as I couldn't find much info about keeping the main head static between transitions AND the aside between docs pages.