Skip to content

Conversation

@o0h
Copy link
Owner

@o0h o0h commented Aug 4, 2025

This pull request updates several test methods to improve clarity and consistency in naming conventions for data providers and their return types. The changes primarily involve renaming data provider methods and adding type annotations to enhance readability and maintainability.

Updates to data providers:

  • tests/unit/Differ/DiffCollectorTest.php: Renamed the data provider method getPhpDiffsAstChangedProvider to provideGetPhpDiffsAstChangedCases and added a type annotation specifying the return type as iterable<array{int, bool, GitInterface, DiffFactory}>. [1] [2]
  • tests/unit/Differ/DiffFactoryTest.php: Renamed the data provider method createForPhpProvider to provideCreateForPhpCases and added a type annotation specifying the return type as iterable<array{GitStatus, ?string, ?string}>. [1] [2]

@o0h o0h merged commit 2ca5570 into main Aug 4, 2025
6 checks passed
@o0h o0h deleted the fix-cs branch August 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants