[WIP] Proof functions + native prover demo #3366
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2025
querolita
reviewed
Nov 10, 2025
|
|
||
| #[napi(js_name = "pasta_fp_plonk_index_max_degree")] | ||
| pub fn caml_pasta_fp_plonk_index_max_degree(index: &External<NapiPastaFpPlonkIndex>) -> i32 { | ||
| pub fn caml_pasta_fp_plonk_index_max_degree(index: &External<WasmPastaFpPlonkIndex>) -> i32 { |
Member
There was a problem hiding this comment.
Shouldn't the js_name be caml_pasta_fp_plonk_index_max_degree instead of just pasta_fp_plonk_index_max_degree? Same for the rest
| srs: Vec<u8>, | ||
| } | ||
|
|
||
| impl NapiPastaFpPlonkIndex { |
Member
There was a problem hiding this comment.
Mmmm doesn't #[napi(js_name = "WasmPastaFpPlonkIndex")] work here? I was trying to rename at the napi level these functions so they are prefixed Napi inside plonk-napi, but then read as Wasm- from outside.
querolita
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3366
MinaProtocol/mina#18079
o1-labs/o1js#2628