feat: upgrade FontAwesome to version 7 with new package strucutre #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structure Add comprehensive FontAwesome 7 support by splitting into separate packages for each style variant. This includes 3 free variants (brands, regular, solid) and 15 pro variants covering standard, duotone, and sharp styles across different weights. Key changes: - Add 18 new FontAwesome packages (3 free, 15 pro) - Update main README to list FontAwesome 7 (7.1.0) as current version with 2,806 free and 75,767 pro icons - Move FontAwesome 6 to "no longer maintained upstream" section - Add generate-fontawesome-glyphmap.mts script for generating package-specific glyphmaps from upstream CSS - Update fetch-pro.sh script with improved shell quoting - Regenerate fonts for ant-design, entypo, and evil-icons - Update directory package to clean generated files before rebuilding - Update various package READMEs with formatting improvements - Update generator template README
Collaborator
Author
Closed
Owner
|
Only reviewed on my phone so didn't run test it, but LGTM! |
vonovak
reviewed
Oct 29, 2025
| } | ||
| const codePoint = Number.parseInt(content.slice(1), 16); | ||
| let codePoint = Number.parseInt(content.slice(1), 16); | ||
| if (Number.isNaN(codePoint)) { |
Collaborator
Author
There was a problem hiding this comment.
In FA7 most are what you'd expect e.g.
.fa-caravan-simple {
--fa: "\e000";
}But they have a bunch like this
.fa-bracket {
--fa: "\[";
}
.fa-bracket-left {
--fa: "\[";
}
.fa-slash-back {
--fa: "\\";
}So we need to convert the ASCII character into a code point
vonovak
reviewed
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive FontAwesome 7 support by splitting into
separate packages for each style variant. This includes 3 free
variants (brands, regular, solid) and 15 pro variants covering
standard, duotone, and sharp styles across different weights.
Key changes:
version with 2,806 free and 75,767 pro icons
package-specific glyphmaps from upstream CSS
rebuilding