Fix RuntimeWarning: 'tf2onnx.convert' found in sys.modules after import of package 'tf2onnx', but prior to execution of 'tf2onnx.convert' #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt of package 'tf2onnx', but prior to execution of 'tf2onnx.convert' Signed-off-by: Adraub <[email protected]>
xadupre
approved these changes
Nov 3, 2025
Fixes some UT missing some submodules after removing heavy import Signed-off-by: Adraub <[email protected]>
|
I added lazy loading of the submodules, it fixes the initial warning and the UT error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
python -m tf2onnx.convertto convert a model i got this warning :I looked for the root reason, and it seems most module are eagerly imported directly in the __init__.py while nothing seems to justify it.
It also happened to others (see #1831) and can be confusing when your conversion is going wrong.
I think these lines should be removed, i ran the tests and found no regressions.