Skip to content

super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023) + refactor of the spectral sampling logic to enable deterministic/pseudorandom/quasirandom choice for each sampling type #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023) + refactor of the spectral sampling logic to enable deterministic/pseudorandom/quasirandom choice for each sampling type #1651

wants to merge 50 commits into from
+16,435 −151

Conversation

@emmacware
Copy link
Collaborator

@emmacware emmacware commented Jun 16, 2025

No description provided.

@slayoo slayoo changed the title Matsushima Alpha Parameterization super-droplet attribute sampling: new example based on alpha-parameterisation from Matsushima et al. 2023 Jun 16, 2025
@emmacware
Copy link
Collaborator Author

emmacware commented Jun 20, 2025 •
edited by slayoo
Loading

  • ConstantMultiplicity is only approximately constant currently
  • tf tests have high tolerances for CM...
  • The figure looks a little off, potentially it is the aerosol distribution and not the sampling?

@slayoo slayoo mentioned this pull request Jun 24, 2025
Open
8 tasks
@slayoo
Copy link
Member

slayoo commented Jul 23, 2025

closing as it is now part of #1687

@slayoo slayoo closed this Jul 23, 2025
@slayoo slayoo reopened this Sep 17, 2025
@slayoo
Copy link
Member

slayoo commented Sep 17, 2025

@emmacware, reopened this PR to separate the alpha-sampling changes from the Hill & Shipway PR (#1687).
Thus, removed any changes to the H&S example from this PR.
The remaining notebook here is the Matsushima et al. fig 1. However, it looks pretty different from the paper - is it intentional?
this PR:
image
paper:
image
It would be great to add a smoke test asserting on the features of this plot.

@slayoo slayoo changed the title super-droplet attribute sampling: new example based on alpha-parameterisation from Matsushima et al. 2023 super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023) Sep 17, 2025
@slayoo
Copy link
Member

slayoo commented Oct 16, 2025

@emmacware, please push here the fix removing the "wiggle" - let's try to merge it!
Thanks

@slayoo
Copy link
Member

slayoo commented Nov 24, 2025

thank you @emmacware !

slayoo added 16 commits November 25, 2025 00:44
@slayoo slayoo changed the title super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023) super-droplet attribute "alpha" sampling (incl. new example based on Fig 1 from Matsushima et al. 2023) + refactor of the spectral sampling logic to enable deterministic/pseudorandom/quasirandom choice for each sampling type Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

priority-high

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emmacware @slayoo @AgnieszkaZaba @tluettm