-
Notifications
You must be signed in to change notification settings - Fork 839
fix(accelerator): Adding name method in XPUAccelerator #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added the name method to fix an issue related to a newly added feature in lightning 2.5.6 Signed-off-by: Niclas <[email protected]>
Signed-off-by: Niclas <[email protected]>
Signed-off-by: Niclas <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This is my first ever pull request. So please excuse some beginner mistakes or strange workflows. However, feel free to tell me what I did wrong and how to do it right. |
Signed-off-by: Niclas <[email protected]>
Signed-off-by: Niclas <[email protected]>
rajeshgangireddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the fix on a machine with xpu with lightning 2.5.5 as well as lightning 2.5.6 It's working.
Thanks for the contribution.
|
@waschsalz |
I did that for the latest commit and it worked through all tests. |
Signed-off-by: waschsalz <[email protected]>
…tform#3108) * Update xpu.py regarind PR open-edge-platform#3092 Added the name method to fix an issue related to a newly added feature in lightning 2.5.6 Signed-off-by: Niclas <[email protected]> * Update xpu.py Signed-off-by: Niclas <[email protected]> * Update xpu.py Signed-off-by: Niclas <[email protected]> * Update xpu.py with docstring Signed-off-by: Niclas <[email protected]> * Update xpu.py with correct docstring Signed-off-by: Niclas <[email protected]> * added name method for XPUAccelerator Signed-off-by: waschsalz <[email protected]> --------- Signed-off-by: Niclas <[email protected]> Signed-off-by: waschsalz <[email protected]>
…tform#3108) * Update xpu.py regarind PR open-edge-platform#3092 Added the name method to fix an issue related to a newly added feature in lightning 2.5.6 Signed-off-by: Niclas <[email protected]> * Update xpu.py Signed-off-by: Niclas <[email protected]> * Update xpu.py Signed-off-by: Niclas <[email protected]> * Update xpu.py with docstring Signed-off-by: Niclas <[email protected]> * Update xpu.py with correct docstring Signed-off-by: Niclas <[email protected]> * added name method for XPUAccelerator Signed-off-by: waschsalz <[email protected]> --------- Signed-off-by: Niclas <[email protected]> Signed-off-by: waschsalz <[email protected]> Signed-off-by: Alfie Roddan <[email protected]>
📝 Description
namemethod #3092✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.