Skip to content

Conversation

@waschsalz
Copy link
Contributor

@waschsalz waschsalz commented Nov 12, 2025

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Added the name method to fix an issue related to a newly added feature in lightning 2.5.6

Signed-off-by: Niclas <[email protected]>
Signed-off-by: Niclas <[email protected]>
Signed-off-by: Niclas <[email protected]>
samet-akcay
samet-akcay previously approved these changes Nov 12, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@waschsalz
Copy link
Contributor Author

📝 Description

* added the name method for the XPUAccelerator to be compatible with lightning version 5.2.6

* changed the naming method in the registering step

* 🛠️ Fixes [📋 [TASK] Update XPUAccelerator  with `name` method #3092](https://github.com/open-edge-platform/anomalib/issues/3092)

✨ Changes

Select what type of change your PR is:

* [ ]  🚀 New feature (non-breaking change which adds functionality)

* [x]  🐞 Bug fix (non-breaking change which fixes an issue)

* [ ]  🔄 Refactor (non-breaking change which refactors the code base)

* [ ]  ⚡ Performance improvements

* [ ]  🎨 Style changes (code style/formatting)

* [ ]  🧪 Tests (adding/modifying tests)

* [ ]  📚 Documentation update

* [ ]  📦 Build system changes

* [ ]  🚧 CI/CD configuration

* [ ]  🔧 Chore (general maintenance)

* [ ]  🔒 Security update

* [ ]  💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

* [x]  📚 I have made the necessary updates to the documentation (if applicable).

* [ ]  🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

* [x]  🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

This is my first ever pull request. So please excuse some beginner mistakes or strange workflows. However, feel free to tell me what I did wrong and how to do it right.

@waschsalz waschsalz changed the title fix[accelerator]: adding name method in XPUAccelerator fix(accelerator): adding name method in XPUAccelerator Nov 12, 2025
@rajeshgangireddy rajeshgangireddy changed the title fix(accelerator): adding name method in XPUAccelerator fix(accelerator): Adding name method in XPUAccelerator Nov 12, 2025
Copy link
Contributor

@rajeshgangireddy rajeshgangireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the fix on a machine with xpu with lightning 2.5.5 as well as lightning 2.5.6 It's working.
Thanks for the contribution.

@rajeshgangireddy
Copy link
Contributor

@waschsalz
Can you please also run pre-commit hooks.
See here : https://github.com/open-edge-platform/anomalib/blob/main/CONTRIBUTING.md

@waschsalz
Copy link
Contributor Author

@waschsalz Can you please also run pre-commit hooks. See here : https://github.com/open-edge-platform/anomalib/blob/main/CONTRIBUTING.md

I did that for the latest commit and it worked through all tests.

@rajeshgangireddy rajeshgangireddy merged commit f006ab7 into open-edge-platform:main Nov 13, 2025
15 checks passed
Rickypanta0 pushed a commit to Rickypanta0/anomalib that referenced this pull request Nov 13, 2025
…tform#3108)

* Update xpu.py regarind PR open-edge-platform#3092

Added the name method to fix an issue related to a newly added feature in lightning 2.5.6

Signed-off-by: Niclas <[email protected]>

* Update xpu.py

Signed-off-by: Niclas <[email protected]>

* Update xpu.py

Signed-off-by: Niclas <[email protected]>

* Update xpu.py with docstring

Signed-off-by: Niclas <[email protected]>

* Update xpu.py with correct docstring

Signed-off-by: Niclas <[email protected]>

* added name method for XPUAccelerator

Signed-off-by: waschsalz <[email protected]>

---------

Signed-off-by: Niclas <[email protected]>
Signed-off-by: waschsalz <[email protected]>
alfieroddanintel pushed a commit to alfieroddanintel/anomalib that referenced this pull request Nov 13, 2025
…tform#3108)

* Update xpu.py regarind PR open-edge-platform#3092

Added the name method to fix an issue related to a newly added feature in lightning 2.5.6

Signed-off-by: Niclas <[email protected]>

* Update xpu.py

Signed-off-by: Niclas <[email protected]>

* Update xpu.py

Signed-off-by: Niclas <[email protected]>

* Update xpu.py with docstring

Signed-off-by: Niclas <[email protected]>

* Update xpu.py with correct docstring

Signed-off-by: Niclas <[email protected]>

* added name method for XPUAccelerator

Signed-off-by: waschsalz <[email protected]>

---------

Signed-off-by: Niclas <[email protected]>
Signed-off-by: waschsalz <[email protected]>
Signed-off-by: Alfie Roddan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📋 [TASK] Update XPUAccelerator with name method

4 participants