Skip to content

Conversation

@camiloHimura
Copy link

📝 Description

This PR ensures that the pipeline is enabled before playing the WebRTC stream and automatically starts playback once the pipeline becomes active after the app loads.

Screen.Recording.2025-11-12.at.21.11.13.mov
  • Provide a clear summary of the changes and the issue that has been addressed.
  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copilot AI review requested due to automatic review settings November 12, 2025 20:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automatic playback of WebRTC streams by ensuring the pipeline is enabled before streaming begins and automatically starting playback when the pipeline becomes active after app load.

  • Refactors useEnablePipeline hook to accept an onSuccess callback for better stream initiation control
  • Adds autoplay logic that triggers WebRTC connection when pipeline status is running
  • Improves UI/UX by consolidating connection status display and disabling controls when source/sink are missing

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
application/ui/src/setup-tests.ts Adds ResizeObserver mock for test environment
application/ui/src/hooks/use-pipeline.hook.ts Refactors hook to accept onSuccess callback and centralize error handling
application/ui/src/features/inspect/toolbar/toolbar.tsx Removes redundant WebRTC connection status component
application/ui/src/features/inspect/toolbar/sources/source-options.component.tsx Temporarily disables images folder source option
application/ui/src/features/inspect/toolbar/pipeline-switch/web-rtc-connection-status.component.tsx Updates connection status display with tooltip and corrects variant
application/ui/src/features/inspect/toolbar/pipeline-switch/pipeline-switch.module.scss Adds margin styling for switch component
application/ui/src/features/inspect/toolbar/pipeline-switch/pipeline-switch.component.tsx Consolidates pipeline control logic and adds connection status display
application/ui/src/features/inspect/stream/stream.tsx Simplifies stream component by removing conditional rendering
application/ui/src/features/inspect/stream/stream-container.tsx Implements autoplay logic and pipeline enablement flow
application/ui/src/features/inspect/stream/stream-container.test.tsx Adds comprehensive test coverage for stream container functionality
application/ui/mocks/mock-pipeline.ts Creates reusable mock pipeline factory for tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</div>
<video
ref={videoRef}
muted
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modern browsers don’t allow videos to autoplay unless the user has interacted with the page at least once. Muting the video lets us bypass that restriction.

@camiloHimura camiloHimura force-pushed the ccolora11/disable-project branch from 192698d to d8d4f1f Compare November 12, 2025 20:20
Signed-off-by: Colorado, Camilo <[email protected]>
Copilot AI review requested due to automatic review settings November 12, 2025 21:20
@camiloHimura camiloHimura force-pushed the ccolora11/disable-project branch from d8d4f1f to c457cc4 Compare November 12, 2025 21:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camiloHimura camiloHimura merged commit ab12f0e into open-edge-platform:feature/geti-inspect Nov 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants