-
Notifications
You must be signed in to change notification settings - Fork 841
feat(inspect): Stream autoplay #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inspect): Stream autoplay #3110
Conversation
Signed-off-by: Colorado, Camilo <[email protected]>
Signed-off-by: Colorado, Camilo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic playback of WebRTC streams by ensuring the pipeline is enabled before streaming begins and automatically starting playback when the pipeline becomes active after app load.
- Refactors
useEnablePipelinehook to accept anonSuccesscallback for better stream initiation control - Adds autoplay logic that triggers WebRTC connection when pipeline status is running
- Improves UI/UX by consolidating connection status display and disabling controls when source/sink are missing
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/setup-tests.ts | Adds ResizeObserver mock for test environment |
| application/ui/src/hooks/use-pipeline.hook.ts | Refactors hook to accept onSuccess callback and centralize error handling |
| application/ui/src/features/inspect/toolbar/toolbar.tsx | Removes redundant WebRTC connection status component |
| application/ui/src/features/inspect/toolbar/sources/source-options.component.tsx | Temporarily disables images folder source option |
| application/ui/src/features/inspect/toolbar/pipeline-switch/web-rtc-connection-status.component.tsx | Updates connection status display with tooltip and corrects variant |
| application/ui/src/features/inspect/toolbar/pipeline-switch/pipeline-switch.module.scss | Adds margin styling for switch component |
| application/ui/src/features/inspect/toolbar/pipeline-switch/pipeline-switch.component.tsx | Consolidates pipeline control logic and adds connection status display |
| application/ui/src/features/inspect/stream/stream.tsx | Simplifies stream component by removing conditional rendering |
| application/ui/src/features/inspect/stream/stream-container.tsx | Implements autoplay logic and pipeline enablement flow |
| application/ui/src/features/inspect/stream/stream-container.test.tsx | Adds comprehensive test coverage for stream container functionality |
| application/ui/mocks/mock-pipeline.ts | Creates reusable mock pipeline factory for tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tion/ui/src/features/inspect/toolbar/pipeline-switch/web-rtc-connection-status.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/stream/stream-container.tsx
Outdated
Show resolved
Hide resolved
| </div> | ||
| <video | ||
| ref={videoRef} | ||
| muted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modern browsers don’t allow videos to autoplay unless the user has interacted with the page at least once. Muting the video lets us bypass that restriction.
192698d to
d8d4f1f
Compare
Signed-off-by: Colorado, Camilo <[email protected]>
d8d4f1f to
c457cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tion/ui/src/features/inspect/toolbar/pipeline-switch/web-rtc-connection-status.component.tsx
Show resolved
Hide resolved
ab12f0e
into
open-edge-platform:feature/geti-inspect
📝 Description
This PR ensures that the pipeline is enabled before playing the WebRTC stream and automatically starts playback once the pipeline becomes active after the app loads.
Screen.Recording.2025-11-12.at.21.11.13.mov
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.