[receiver/kafka] Add support for exclude topics when using regex #44118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
paulojmdias
requested review from
a team,
MovieStoreGuy and
axw
as code owners
Signed-off-by: Paulo Dias <[email protected]>
…lector-contrib into feat/43782 Signed-off-by: Paulo Dias <[email protected]>
atoulme
reviewed
Nov 9, 2025
| config *Config, | ||
| set receiver.Settings, | ||
| topics []string, | ||
| excludeTopics []string, |
Member
Author
There was a problem hiding this comment.
Built this way to keep the same input type as the topic field, which is defined in config as a string but is set here as an array. I'm open to supporting this as an array (maybe renamed to exclude_topics), but for parity, IMO we should fill an issue to evaluate transforming the topic field into a native list of strings too.
I would like to have inputs here from the other codeowners @axw, @MovieStoreGuy, and @pavolloffay 🙏
atoulme
reviewed
Nov 9, 2025
| }, nil | ||
| } | ||
| return newReceiver(config, set, []string{config.Logs.Topic}, newConsumeMessageFunc) | ||
| return newReceiver(config, set, []string{config.Logs.Topic}, []string{config.Logs.ExcludeTopic}, newConsumeMessageFunc) |
Contributor
There was a problem hiding this comment.
did you mean to make this an array of string in the config?
atoulme
reviewed
Nov 9, 2025
atoulme
reviewed
Nov 9, 2025
Signed-off-by: Paulo Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
exclude_topicoption to allow users to exclude topics when using the Kafka receiver with a regex on the topic consuming definition.Link to tracking issue
Fixes #43782
Testing
Added tests to validate this functionality and the configuration itself.
Documentation
Updated documentation with the option and with an explicit example.