chore(tracer): add a workaround to allow running under race sanitizer #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos68k
approved these changes
Oct 29, 2025
| // workaround for "fatal error: checkptr: converted pointer straddles multiple allocations" | ||
| fullSizeCopy := make([]byte, unsafe.Sizeof(support.Trace{})) | ||
| copy(fullSizeCopy, raw) | ||
| return (*support.Trace)(unsafe.Pointer(unsafe.SliceData(fullSizeCopy))) |
Member
There was a problem hiding this comment.
Compared to norace, this logic results in a different Trace.Hash (as the writes to raw through the pointer don't take effect) but since we don't use this hash at all anymore I opened #901 to remove it.
florianl
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run the profiler under
-racesanitizier I get the following errorThe error is false positive since the code has proper checks to not access all frames out of bounds.
This PR adds a workaround that creates a copy of the whole trace with a larger buffer (
sizeof(Trace)) to make thecheckptrhappy.This would simplify catching races like #899
As an alternative, I had an idea to change the Trace structure layout - split into multiple structures
TraceHeader,Trace(which includes the headers and the frames). But that would require changes in the bpf code and seem slightly less C-idiomatic so I did not choose this option.