Jdbc declarative config params #15199
Open
+71
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
|
@trask please have a look |
jeanbisutti
reviewed
Nov 3, 2025
| return false; | ||
| } | ||
|
|
||
| return instrumentationConfig |
There was a problem hiding this comment.
Are there tests for declarative configuration applied to the JDBC instrumentation?
There was a problem hiding this comment.
to early for that - I first want to discuss if this approach is better than #14767
| } | ||
|
|
||
| private static boolean transactionEnabled(OpenTelemetry openTelemetry, boolean defaultEnabled) { | ||
| if (openTelemetry instanceof ExtendedOpenTelemetry) { |
There was a problem hiding this comment.
(minor) The else could be removed in this way:
if (!openTelemetry instanceof ExtendedOpenTelemetry) {
return ConfigPropertiesUtil.getBoolean(
"otel.instrumentation.jdbc.experimental.transaction.enabled", defaultEnabled);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out using the declarative config API directly as discussed in #14767
It feels quite verbose - but let's use it as a start for the discussion