Sql sanitizer should by default treat double-quoted fragments as string literals #15582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
laurit
commented
Dec 9, 2025
Comment on lines
+28
to
+33
| "oracle", | ||
| "h2", | ||
| "hsqldb", | ||
| "db2", | ||
| "derby", | ||
| "hanadb")); |
Contributor
Author
There was a problem hiding this comment.
google ai believes that these dbs don't support string literals in double quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sql databases allow placing string literals in double quotes. Other databases use double quotes for quoting identifiers (ansi standard uses that). Or sql sanitizer is not sophisticated enough to deduce from context whether a double quoted substring could represent a literal or an identifier so we must err on the side of caution and sanitize the double quoted strings unless we know that query is executed on a database that does not support double quoted string literals e.g. postgres.