-
Notifications
You must be signed in to change notification settings - Fork 1k
Rename span-suppression-strategy configuration with backward compatibility #15612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rename span-suppression-strategy configuration with backward compatibility #15612
Conversation
trask
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth copying DeprecatedConfigProperties.java into this module (just to stay consistent with this pattern)
1c4d5da to
876fc97
Compare
acfcd29 to
8510b68
Compare
|
Thanks! I have now copied DeprecatedConfigProperties.java into the instrumentation-api module as suggested, to stay consistent with the project structure. The PR has been updated accordingly. |
8510b68 to
a176bf8
Compare
a176bf8 to
ceaad7e
Compare
| * any time. | ||
| */ | ||
| @SuppressWarnings("unused") | ||
| public final class DeprecatedConfigProperties { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems this class isn't used
This PR renames the configuration key:
otel.instrumentation.experimental.span-suppression-strategy
to the new key:
otel.instrumentation.common.experimental.span-suppression-strategy
Changes:
Fixes #15566