update declarative config to 1.0-rc.2 #1733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* suppress some new psalm complaints * apply x2 rector suggested fixes
- adds service detector - configurator name and config are not required see https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1 and https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.2
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
============================================
+ Coverage 68.26% 68.36% +0.09%
- Complexity 2970 2972 +2
============================================
Files 448 449 +1
Lines 9029 9035 +6
============================================
+ Hits 6164 6177 +13
+ Misses 2865 2858 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Nevay
reviewed
Oct 29, 2025
| ->end() | ||
| ->end() | ||
| ->end() | ||
| ->scalarNode('translation_strategy')->defaultValue('UnderscoreEscapingWithSuffixes')->end() |
There was a problem hiding this comment.
Should remove without_units and without_type_suffix as these two options were replaced by translation_strategy.
Iff we want to be explicit about the allowed values:
Suggested change
| ->scalarNode('translation_strategy')->defaultValue('UnderscoreEscapingWithSuffixes')->end() | |
| ->enumNode('translation_strategy') | |
| ->defaultValue('UnderscoreEscapingWithSuffixes') | |
| ->values([ | |
| 'UnderscoreEscapingWithSuffixes', | |
| 'UnderscoreEscapingWithoutSuffixes', | |
| 'NoUTF8EscapingWithSuffixes', | |
| 'NoTranslation', | |
| ]) | |
| ->end() |
Comment on lines
-560
to
-571
| # Configure response propagators. | ||
| # If omitted, a noop response propagator is used. | ||
| response_propagator/development: | ||
| # Configure the experimental response propagators in the composite experimental response propagator. Entries from .composite_list are appended to the list here with duplicates filtered out. | ||
| # Built-in experimental response propagator keys include: N/A. Known third party keys include: servertiming, traceresponse. | ||
| # If the resolved list of experimental response propagators (from .composite and .composite_list) is empty, a noop response propagator is used. | ||
| composite: | ||
| # Configure the experimental response propagators in the composite experimental response propagator. Entries are appended to .composite with duplicates filtered out. | ||
| # The value is a comma separated list of experimental response propagator identifiers matching the format of OTEL_EXPERIMENTAL_RESPONSE_PROPAGATORS. See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#general-sdk-configuration for details. | ||
| # Built-in experimental propagator identifiers include: N/A. Known third party identifiers include: servertiming, traceresponse. | ||
| # If the resolved list of experimental propagators (from .composite and .composite_list) is empty, a noop response propagator is used. | ||
| composite_list: "servertiming,traceresponse" |
There was a problem hiding this comment.
Might want to undo this change as this is a PHP-specific node.
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->booleanNode('disabled')->isRequired()->end() | ||
| ->booleanNode('disabled')->end() |
There was a problem hiding this comment.
Can we add a test with
tracer_provider:
tracer_configurator/development:
tracers:
- name: test
config:| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->booleanNode('disabled')->isRequired()->end() | ||
| ->booleanNode('disabled')->end() |
There was a problem hiding this comment.
Should also remove ->isRequired() from the default_config node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.1 and https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.2