Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Fixed

- Replace Python 3.14-deprecated `asyncio.iscoroutinefunction` with `inspect.iscoroutinefunction`. ([#3880](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3880))

## Version 1.38.0/0.59b0 (2025-10-16)

### Fixed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ async def produce():

from __future__ import annotations

from asyncio import iscoroutinefunction
from inspect import iscoroutinefunction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks something, could you please take a look at the failing tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I’ll fix!

from typing import TYPE_CHECKING, Collection

import aiokafka
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import asyncio
import inspect
import typing
from collections.abc import Coroutine

Expand Down Expand Up @@ -197,7 +197,7 @@ async def __aenter__(self):

async def __aexit__(self, exc_type, exc, t_b):
try:
if asyncio.iscoroutinefunction(self._obj.close):
if inspect.iscoroutinefunction(self._obj.close):
await self._obj.close()
else:
self._obj.close()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ async def async_response_hook(span, request, response):

import logging
import typing
from asyncio import iscoroutinefunction
from functools import partial
from inspect import iscoroutinefunction
from timeit import default_timer
from types import TracebackType

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import abc
import asyncio
import inspect
import typing
from unittest import mock

Expand Down Expand Up @@ -1046,7 +1047,7 @@ def test_custom_tracer_provider(self):
def test_response_hook(self):
response_hook_key = (
"async_response_hook"
if asyncio.iscoroutinefunction(self.response_hook)
if inspect.iscoroutinefunction(self.response_hook)
else "response_hook"
)
response_hook_kwargs = {response_hook_key: self.response_hook}
Expand Down Expand Up @@ -1093,7 +1094,7 @@ def test_response_hook_sync_async_kwargs(self):
def test_request_hook(self):
request_hook_key = (
"async_request_hook"
if asyncio.iscoroutinefunction(self.request_hook)
if inspect.iscoroutinefunction(self.request_hook)
else "request_hook"
)
request_hook_kwargs = {request_hook_key: self.request_hook}
Expand Down
Loading