-
Notifications
You must be signed in to change notification settings - Fork 820
opentelemetry-instrumentation-aiohttp-client: fix metric attribute leakage #3936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@herin049 could you please add the snippet as a test? Also please update the number in the fixes since the current one is about a kafka version |
1282a2a to
92ab1b4
Compare
Contributor
Author
92ab1b4 to
aa74727
Compare
…lation of metric attributes
aa74727 to
f9684c8
Compare
emdneto
requested changes
Nov 17, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Left a small comment about the test, other than that LGTM. Can you please add a changelog entry with the fix?
...tation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py
Show resolved
Hide resolved
emdneto
approved these changes
Nov 18, 2025
Contributor
Author
xrmx
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where all client requests reference the same collection of metric attributes, leading to scenarios where attributes used in one request can spill into attributes from another request.
Fixes #3756
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The original bug can be reproduced by running the following snippet
before the changes in this PR, the first metric data point will correctly have the
http.status_codeattribute set to200, however the second metric data point (associated with the timeout request) also hashttp.status_codeset to200due to the scenario described above. After implementing the changes the second metric data point no longer populateshttp.status_codeas expected.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.