Fix DjangoInstrumentor exemplars generation for http.server.(request.)duration #3945
+243
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
changed the title
herin049
reviewed
Nov 19, 2025
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
13 tasks
herin049
reviewed
Nov 21, 2025
| self.assertTrue(len(metrics_data.resource_metrics) > 0) | ||
|
|
||
| duration_metric = None | ||
| metric_names = [] |
Contributor
There was a problem hiding this comment.
What's the purpose of this variable?
Contributor
Author
There was a problem hiding this comment.
Wasn't used! Repurposed for more assertions in 10d7c56
Comment on lines
+98
to
+111
| for resource_metric in metrics_data.resource_metrics: | ||
| for scope_metric in resource_metric.scope_metrics: | ||
| for metric in scope_metric.metrics: | ||
| metric_names.append(metric.name) | ||
| if metric.name in [ | ||
| "http.server.request.duration", | ||
| "http.server.duration", | ||
| ]: | ||
| duration_metric = metric | ||
| break | ||
| if duration_metric: | ||
| break | ||
| if duration_metric: | ||
| break |
Contributor
There was a problem hiding this comment.
You can also do
Suggested change
| for resource_metric in metrics_data.resource_metrics: | |
| for scope_metric in resource_metric.scope_metrics: | |
| for metric in scope_metric.metrics: | |
| metric_names.append(metric.name) | |
| if metric.name in [ | |
| "http.server.request.duration", | |
| "http.server.duration", | |
| ]: | |
| duration_metric = metric | |
| break | |
| if duration_metric: | |
| break | |
| if duration_metric: | |
| break | |
| duration_metric = next((metric for metric in self.get_sorted_metrics() if metric.name in ("http.server.request.duration", "http.server.duration")), None) |
Contributor
Author
There was a problem hiding this comment.
I'd like to keep it as the spread-out nested loops for visual spoon feed of metrics structure, if that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exemplars are opted into via metrics SDK, this fixes DjangoInstrumentor middleware's generation of exemplars for http.server.request.duration and http.server.duration (new and old semconv respectively) so trace ID and span ID are no longer empty. Similar to Flask fix in #3912 -- test dep updates will conflict
Fixes #3951
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.