-
Notifications
You must be signed in to change notification settings - Fork 820
opentelemetry-instrumentation-redis: implement suppression of instrumentation in Redis commands and pipelines #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx
merged 7 commits into
open-telemetry:main
from
Elyahou:redis-enabled-instrumentation
Nov 20, 2025
Merged
opentelemetry-instrumentation-redis: implement suppression of instrumentation in Redis commands and pipelines #3955
xrmx
merged 7 commits into
open-telemetry:main
from
Elyahou:redis-enabled-instrumentation
Nov 20, 2025
+181
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation in Redis commands and pipelines - Added `suppress_instrumentation` context manager to allow selective disabling of instrumentation for Redis commands and pipelines. - Updated the Redis instrumentation to check if instrumentation is enabled before executing commands. - Added unit tests to verify the functionality of the suppression feature for both synchronous and asynchronous Redis operations.
72142bc to
f7d06b1
Compare
herin049
approved these changes
Nov 19, 2025
emdneto
approved these changes
Nov 20, 2025
Member
emdneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the lint/precommit CI failures?
12 tasks
Contributor
Author
|
@emdneto Thanks for the review. It should be ok now. |
xrmx
reviewed
Nov 20, 2025
...tion/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
Outdated
Show resolved
Hide resolved
…lemetry/instrumentation/redis/__init__.py
xrmx
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2057
suppress_instrumentationcontext manager to allow selective disabling of instrumentation for Redis commands and pipelines.Type of change
New feature
How Has This Been Tested?
Unit-tests + Manual tests in app
Using
suppress_instrumentation()context manager in app around redis operation and check that it does not instrument this callDoes This PR Require a Core Repo Change?
No.
Checklist: