Skip to content

Conversation

@Elyahou
Copy link
Contributor

@Elyahou Elyahou commented Nov 18, 2025

Description

Fix #2057

  • Added support of suppress_instrumentation context manager to allow selective disabling of instrumentation for Redis commands and pipelines.

Type of change

New feature

How Has This Been Tested?

Unit-tests + Manual tests in app

Using suppress_instrumentation() context manager in app around redis operation and check that it does not instrument this call

Does This PR Require a Core Repo Change?

No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

…entation in Redis commands and pipelines

- Added `suppress_instrumentation` context manager to allow selective disabling of instrumentation for Redis commands and pipelines.
- Updated the Redis instrumentation to check if instrumentation is enabled before executing commands.
- Added unit tests to verify the functionality of the suppression feature for both synchronous and asynchronous Redis operations.
@Elyahou Elyahou force-pushed the redis-enabled-instrumentation branch from 72142bc to f7d06b1 Compare November 18, 2025 15:22
@Elyahou Elyahou requested a review from a team as a code owner November 18, 2025 15:22
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the lint/precommit CI failures?

@Elyahou
Copy link
Contributor Author

Elyahou commented Nov 20, 2025

@emdneto Thanks for the review. It should be ok now.

@xrmx xrmx enabled auto-merge (squash) November 20, 2025 15:19
@xrmx xrmx moved this to Approved PRs in @xrmx's Python PR digest Nov 20, 2025
@xrmx xrmx merged commit 4421670 into open-telemetry:main Nov 20, 2025
647 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in @xrmx's Python PR digest Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

RedisInstrumentor doesn't respect "supress_instrumentation" flag

4 participants