Skip to content

Conversation

@owenlin0
Copy link
Contributor

@owenlin0 owenlin0 commented Nov 30, 2025

Emit item/fileChange/outputDelta instead of item/execCommand/outputDelta for FileChange items.

The underlying EventMsg::ExecCommandOutputDelta is emitted for apply_patch, shell, and unified exec, and since we represent apply_patch calls as FileChange items, we were seeing these events:

item/started <- FileChange
item/execCommand/outputDelta <- our code assumed that EventMsg::ExecCommandOutputDelta is always for the CommandExecution item
item/completed <- FileChange

With this fix we'll have these events:

item/started <- FileChange
item/fileChange/outputDelta <- our code assumed that EventMsg::ExecCommandOutputDelta is always for the CommandExecution item
item/completed <- FileChange

@owenlin0 owenlin0 force-pushed the owen/fix_apply_patch_delta branch from b3b69fe to c84a89d Compare November 30, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants