Skip to content

chore: make create_approval_requirement_for_command an async fn #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

chore: make create_approval_requirement_for_command an async fn #7501

merged 1 commit into from
Dec 2, 2025
+32 −24

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Dec 2, 2025 •
edited
Loading

I think this might help with #7033 because create_approval_requirement_for_command() will soon need access to Session.state, which is a tokio::sync::Mutex that needs to be accessed via async.

@bolinfest bolinfest requested a review from zhao-oai December 2, 2025 22:33
@bolinfest bolinfest mentioned this pull request Dec 2, 2025
Merged
zhao-oai
zhao-oai approved these changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@zhao-oai zhao-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks a lot!

@bolinfest bolinfest merged commit ec93b6d into main Dec 2, 2025
26 checks passed
@bolinfest bolinfest deleted the pr7501 branch December 2, 2025 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zhao-oai zhao-oai zhao-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bolinfest @zhao-oai