Skip to content

fix: save conversation to session before handoff for non-streaming path #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: save conversation to session before handoff for non-streaming path #2128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/agents/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,15 @@ async def run(

return result
elif isinstance(turn_result.next_step, NextStepHandoff):
# Save the conversation to session if enabled (before handoff)
if session is not None:
if not any(
guardrail_result.output.tripwire_triggered
for guardrail_result in input_guardrail_results
):
await self._save_result_to_session(
session, [], turn_result.new_step_items
)
current_agent = cast(Agent[TContext], turn_result.next_step.new_agent)
current_span.finish(reset_current=True)
current_span = None
Expand Down Expand Up @@ -1166,8 +1175,7 @@ async def _start_streaming(

if isinstance(turn_result.next_step, NextStepHandoff):
# Save the conversation to session if enabled (before handoff)
# Note: Non-streaming path doesn't save handoff turns immediately,
# but streaming needs to for graceful cancellation support
# Streaming needs to save for graceful cancellation support
if session is not None:
should_skip_session_save = (
await AgentRunner._input_guardrail_tripwire_triggered_for_stream(
Expand Down