Fetch india generation data #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solar_consumer/app.py
Outdated
| country: str = "uk", | ||
| historic_or_forecast: str = "generation", | ||
| ): | ||
| def app(db_url: str, save_method: str, csv_dir: str = None, country: str = "uk"): |
Contributor
There was a problem hiding this comment.
why have you rolled back this change?
solar_consumer/data/fetch_in_data.py
Outdated
| if historic_or_forecast != "generation": | ||
| raise NotImplementedError("Only 'generation' mode is supported for India UPSLDC.") | ||
|
|
||
| # Setup headless browser |
Contributor
There was a problem hiding this comment.
could you not use selenimum here
For example you can use requests, for example
import requests
from bs4 import BeautifulSoup
URL = "https://realpython.github.io/fake-jobs/"
page = requests.get(URL)
soup = BeautifulSoup(page.content, "html.parser")
Contributor
Author
There was a problem hiding this comment.
The solar data is is introduced after the initial HTML is loaded. i tried using BeautifulSoup here but it wont work as the UPSLDC page loads data using JavaScript, which requests and BeautifulSoup arent able to load.
Contributor
There was a problem hiding this comment.
YOu might have to fiddle with portlet_time
Contributor
There was a problem hiding this comment.
page = requests.get(url)
text = page.json(), or something liek that
…climatefix/solar-consumer into Fetch-India-Generation-Data
| import pandas as pd | ||
| from datetime import datetime | ||
|
|
||
| def fetch_in_data(historic_or_forecast="generation"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The update will add the option to fetch generation data from one of the states of India (Uttar Pradesh). This data is publicly available and the current data being fetched is live solar generation data.
How Has This Been Tested?
Ran this programme locally
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: