Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Conversation

@jwasinger
Copy link
Contributor

WIP Don't merge.

Adds support for Clique consensus engine.

@jwasinger
Copy link
Contributor Author

I'm currently using this to test clique locally. To spin up clique cluster using docker-compose:

  • clone this branch and the working branch of clique ([WIP] Clique POA Implementation parity-ethereum#9862 ) to the same directory
  • build parity with clique: cargo build -j4
  • run the build script in this PR: ./build.sh
  • create a deployment cluster configuration. e.g. ./parity-deploy.sh -c clique -n 1 (I haven't tried clique with more than 1 validator)
  • docker-compose up

@ddorgan
Copy link
Collaborator

ddorgan commented Nov 7, 2018

@jwasinger super cool! Let me know once you're done and I can do some testing.

@ddorgan
Copy link
Collaborator

ddorgan commented Nov 27, 2018

Minor issue when running from new checkout....

$ ./parity-deploy.sh --config clique --nodes 2
creating account: deployment/1, deployment/1/spec.BKyXhQP7C
creating account: deployment/2, deployment/2/spec.wYv0BTB9P
cat: config/spec/goerli/parity.goerli.genesis: No such file or directory

Had to cp config/spec/geth/goerli.json config/spec/goerli/parity.goerli.genesis

@deanstef
Copy link

Sorry is this working?

@jwasinger
Copy link
Contributor Author

Yeah. It's one hell of a hack to include geth in this script (and it also requires a few other dependencies). I'll write a quick note about how to set it up.

@jwasinger
Copy link
Contributor Author

Unlikely this will get merged in its current form as it is too hacky and un-maintainable. I talked to @ddorgan at EthCC and there was the idea of rewriting this tool in another language (I think he suggested Rust). I would personally go with Python... but anyways that is unrelated.

@deanstef
Copy link

deanstef commented Mar 13, 2019

Cool! I would definitely use it, and I look forward your setting up notes. BTW where is the repository? Could I have a look at your script?

However I am a bit confused. I read something about porting Clique consensus engine in Parity (Görli project?). Are you involved in it? Which Ethereum client are you using to deploy a Clique network, Parity or Geth?

Unlikely this will get merged in its current form as it is too hacky and un-maintainable. I talked to @ddorgan at EthCC and there was the idea of rewriting this tool in another language (I think he suggested Rust). I would personally go with Python... but anyways that is unrelated.

I am rewriting this tool as well with more functionalities, integrating the Validator Contract configuration. I would be pleased to help you with the new version in Python.

@deanstef
Copy link

deanstef commented Jul 2, 2019

Yeah. It's one hell of a hack to include geth in this script (and it also requires a few other dependencies). I'll write a quick note about how to set it up.

Hey! Do you have the guide for it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants