Skip to content

Conversation

@rgee0
Copy link
Contributor

@rgee0 rgee0 commented Jul 16, 2018

Signed-off-by: Richard Gee [email protected]

Description

This change replaces the -s option for shasum, which suppresses output, in favour of redirection to /dev/null.

Motivation and Context

As part of the graceful degradation change use of sha256sum was introduced.
On Ubuntu 16.04 the shorthand flag for status does not exist which results in
a failure when verifying the checksum. Further, support for -s & the long --status flag
is inconsistent across distros.

How Has This Been Tested?

Pre-tested on Ubuntu 16.04 to validate reported issue
Post-tested on Ubuntu 16.04, MacOS and PWD to get a broad coverage of scenarios.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

As part of the graceful degradation change use of sha256sum was introduced.
On Ubuntu 16.04 the shorthand flag for status does not exist which results in
a failure when verifying the checksum.  Further, support for -s & the long --status
is inconsistent across distros.  This change replaces the -s option which suppresses
output in favour of redirection to /dev/null.

Signed-off-by: Richard Gee <[email protected]>
@alexellis
Copy link
Member

Since this has been tested and seems urgent (we have a workshop on today at OSCON) I'll merge right away.

@alexellis alexellis merged commit 172388b into openfaas:master Jul 16, 2018
@rgee0 rgee0 deleted the fixGetsh branch July 16, 2018 19:58
@alexellis
Copy link
Member

PRETTY_NAME="Ubuntu 16.04.4 LTS"

~$ curl -sLf cli.openfaas.com | sudo sh

You already have the faas-cli!
Overwriting in 1 seconds.. Press Control+C to cancel.

x86_64
Downloading package https://github.com/openfaas/faas-cli/releases/download/0.6.13/faas-cli as /tmp/faas-cli
Download complete.

Running as root - Attempting to move faas-cli to /usr/local/bin
New version of faas-cli installed to /usr/local/bin
  ___                   _____           ____
 / _ \ _ __   ___ _ __ |  ___|_ _  __ _/ ___|
| | | | '_ \ / _ \ '_ \| |_ / _` |/ _` \___ \
| |_| | |_) |  __/ | | |  _| (_| | (_| |___) |
 \___/| .__/ \___|_| |_|_|  \__,_|\__,_|____/
      |_|

Commit: 8ded58db45e83219347b8ba7a719b85bcbd7830e
Version: 0.6.13

@alexellis
Copy link
Member

MacOS

curl -sLf cli.openfaas.com | sudo sh
Password:

You already have the faas-cli!
Overwriting in 1 seconds.. Press Control+C to cancel.

Downloading package https://github.com/openfaas/faas-cli/releases/download/0.6.13/faas-cli-darwin as /tmp/faas-cli-darwin
Download complete.

Running as root - Attempting to move faas-cli to /usr/local/bin
New version of faas-cli installed to /usr/local/bin
  ___                   _____           ____
 / _ \ _ __   ___ _ __ |  ___|_ _  __ _/ ___|
| | | | '_ \ / _ \ '_ \| |_ / _` |/ _` \___ \
| |_| | |_) |  __/ | | |  _| (_| | (_| |___) |
 \___/| .__/ \___|_| |_|_|  \__,_|\__,_|____/
      |_|

Commit: 8ded58db45e83219347b8ba7a719b85bcbd7830e
Version: 0.6.13

Should we at some point hint that we verified the SHA - for the times we did?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants