Skip to content

Conversation

@welteki
Copy link
Member

@welteki welteki commented Jul 24, 2025

Description

  • Update the chart to support the new dynamic queue-worker and different queue modes.
  • Add recording rule for queue depth scaling
  • Remove the global queueMode parameter. The queue-worker backed by NATS JetStream is now always used when openfaasPro=true
  • Remove left over parameters only used for the legacy NATS streaming pro queue-worker

Why is this needed?

  • I have raised an issue to propose this change (required)

Update chart for new queue worker

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Verified the chart renders correctly using helm template.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis alexellis requested a review from Copilot July 25, 2025 07:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates OpenFaaS charts to support new queue modes and queue depth scaling capabilities. The changes transition from a legacy queue system to a modern JetStream-based architecture with improved scalability and configuration options.

  • Refactored queue worker configuration to support both static and function-based queue modes
  • Added queue depth scaling metric recording rule for Prometheus monitoring
  • Removed deprecated global queueMode parameter in favor of automatic JetStream usage for OpenFaaS Pro

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
chart/queue-worker/values.yaml Added new queue configuration parameters and consumer settings
chart/queue-worker/templates/deployment.yaml Updated environment variables to support new queue modes and reorganized configuration
chart/queue-worker/README.md Updated documentation with new configuration parameters and corrected typos
chart/openfaas/values.yaml Removed deprecated queueMode parameter and updated JetStream worker configuration
chart/openfaas/values-pro.yaml Removed deprecated JetStream queue mode setting
chart/openfaas/templates/queueworker-dep.yaml Refactored to use JetStream queue worker for OpenFaaS Pro
chart/openfaas/templates/queueworker-ce-dep.yaml New template for Community Edition queue worker
chart/openfaas/templates/prometheus-pro-cfg.yaml Added recording rule for queue depth scaling metrics
chart/openfaas/templates/nats-dep.yaml Updated NATS deployment logic to use OpenFaaS Pro flag
chart/openfaas/templates/jetstream-queueworker-dep.yaml Removed deprecated JetStream queue worker template
chart/openfaas/templates/gateway-dep.yaml Removed deprecated JetStream environment variable
chart/openfaas/README.md Updated documentation to reflect new queue configuration
Comments suppressed due to low confidence (2)

chart/openfaas/values.yaml:223

  • This appears to be a development/testing image from ttl.sh. For a production chart, this should be changed to an official release image from the proper registry.
  image: ttl.sh/welteki/jetstream-queue-worker:0.3.46-30-g1c16703

chart/openfaas/templates/queueworker-dep.yaml:80

  • [nitpick] Environment variable name is inconsistent with other environment variables. Should be consumer_inactive_threshold to match the pattern used for other consumer-related variables.
        - name: "inactive_threshold"

@alexellis
Copy link
Member

Seems valid

Screenshot 2025-07-25 at 08 40 17

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
welteki added 3 commits July 25, 2025 10:47
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
@alexellis alexellis merged commit 28615ab into openfaas:master Jul 25, 2025
2 checks passed
@welteki welteki deleted the queue-worker branch July 28, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants