-
Notifications
You must be signed in to change notification settings - Fork 492
Update charts to support queue modes and queue depth scaling #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates OpenFaaS charts to support new queue modes and queue depth scaling capabilities. The changes transition from a legacy queue system to a modern JetStream-based architecture with improved scalability and configuration options.
- Refactored queue worker configuration to support both static and function-based queue modes
- Added queue depth scaling metric recording rule for Prometheus monitoring
- Removed deprecated global
queueModeparameter in favor of automatic JetStream usage for OpenFaaS Pro
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chart/queue-worker/values.yaml | Added new queue configuration parameters and consumer settings |
| chart/queue-worker/templates/deployment.yaml | Updated environment variables to support new queue modes and reorganized configuration |
| chart/queue-worker/README.md | Updated documentation with new configuration parameters and corrected typos |
| chart/openfaas/values.yaml | Removed deprecated queueMode parameter and updated JetStream worker configuration |
| chart/openfaas/values-pro.yaml | Removed deprecated JetStream queue mode setting |
| chart/openfaas/templates/queueworker-dep.yaml | Refactored to use JetStream queue worker for OpenFaaS Pro |
| chart/openfaas/templates/queueworker-ce-dep.yaml | New template for Community Edition queue worker |
| chart/openfaas/templates/prometheus-pro-cfg.yaml | Added recording rule for queue depth scaling metrics |
| chart/openfaas/templates/nats-dep.yaml | Updated NATS deployment logic to use OpenFaaS Pro flag |
| chart/openfaas/templates/jetstream-queueworker-dep.yaml | Removed deprecated JetStream queue worker template |
| chart/openfaas/templates/gateway-dep.yaml | Removed deprecated JetStream environment variable |
| chart/openfaas/README.md | Updated documentation to reflect new queue configuration |
Comments suppressed due to low confidence (2)
chart/openfaas/values.yaml:223
- This appears to be a development/testing image from ttl.sh. For a production chart, this should be changed to an official release image from the proper registry.
image: ttl.sh/welteki/jetstream-queue-worker:0.3.46-30-g1c16703
chart/openfaas/templates/queueworker-dep.yaml:80
- [nitpick] Environment variable name is inconsistent with other environment variables. Should be
consumer_inactive_thresholdto match the pattern used for other consumer-related variables.
- name: "inactive_threshold"
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>

Description
queueModeparameter. The queue-worker backed by NATS JetStream is now always used whenopenfaasPro=trueWhy is this needed?
Update chart for new queue worker
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Verified the chart renders correctly using
helm template.Types of changes
Checklist:
git commit -s