fix: remove bogus heights in content pages #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To Discuss & Validate
in 📢 Open Food Facts Marketing
github-project-automation
bot
added this to
🚦Nutri-Score and Ultra-processed foods - NOVA
github-project-automation
bot
moved this to To Discuss & Validate
in Ultra-processed foods - NOVA
hangy
approved these changes
Sep 16, 2025
github-project-automation
bot
moved this from To Discuss & Validate
to In Progress
in 📢 Open Food Facts Marketing
github-project-automation
bot
moved this from To Discuss & Validate
to Todo
in Ultra-processed foods - NOVA
|
@heymitali added that for Explorer because we litteraly had the same issue as Product Opener. cc @VaiTon |
VaiTon
reviewed
Sep 16, 2025
Comment on lines
-244
to
-266
| <script> | ||
| function onMount(fn) { | ||
| if (document.readyState === "loading") { | ||
| document.addEventListener("DOMContentLoaded", fn); | ||
| } else { | ||
| fn(); | ||
| } | ||
| } | ||
|
|
||
| onMount(() => { | ||
| function sendHeight() { | ||
| const height = document.body.scrollHeight; | ||
| console.debug("Calculated height: " + height); | ||
| if (typeof parent !== 'undefined' && parent !== window) { | ||
| parent.postMessage({ frameHeight: height }, '*'); | ||
| } | ||
| } | ||
| // Send the height on initial load | ||
| sendHeight(); | ||
| // Send the height whenever the window is resized | ||
| window.addEventListener("resize", sendHeight); | ||
| }); | ||
| </script> |
Comment on lines
-244
to
-266
| <script> | ||
| function onMount(fn) { | ||
| if (document.readyState === "loading") { | ||
| document.addEventListener("DOMContentLoaded", fn); | ||
| } else { | ||
| fn(); | ||
| } | ||
| } | ||
|
|
||
| onMount(() => { | ||
| function sendHeight() { | ||
| const height = document.body.scrollHeight; | ||
| console.debug("Calculated height: " + height); | ||
| if (typeof parent !== 'undefined' && parent !== window) { | ||
| parent.postMessage({ frameHeight: height }, '*'); | ||
| } | ||
| } | ||
| // Send the height on initial load | ||
| sendHeight(); | ||
| // Send the height whenever the window is resized | ||
| window.addEventListener("resize", sendHeight); | ||
| }); | ||
| </script> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some content pages contain code that was copy pasted from generated equalizer code with fixed heights, removing it.
Fixes openfoodfacts/openfoodfacts-server#12345