Allow using a background queue with OIDAuthState #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is related to this issue: #667, which we also ran into.
The problem was that
OIDAuthorizationService'sperformTokenRequeststill dispatched a lot of callbacks on the main dispatch queue, which in turn caused a deadlock for us when callingOIDAuthState'sperformAction.This change allows setting a queue for OIDAuthState to use when calling
performTokenRequest.This change does not make OIDAuthState thread safe.
The default behaviour stays as is, expecting the user to use the main thread.
If a queue is specified, all method calls on the OIDAuthState then also need to be dispatched from that queue to avoid potential threading issues.